515451 - make places autocomplete empty search behavior customizable

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Right now places autocomplete restricts empty searches to typed history items. Fennec would like unvisited bookmarks to appear in empty searches, so I'd like to make that customizable with a pref.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I decided to have the behavior be fully customizable rather than just additive to the default behavior, which allows more flexibility and is slightly simpler.

Comment 2

[Ed Lee :Mardak]

So we ignore the default behavior/user preference (Privacy -> Location bar suggestions) when the user clicks the dropdown?

The only badness that can occur is if the user selects "Bookmarks" and clicking the dropdown will now show history.

(For the other cases, "History & Bookmarks" is actually "0" and "History" is 1 (?), so just using empty behavior will be correct because it's "33" (32 | 1) and covers both those cases. "None" just turns off the location bar entirely.)

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 399545 [details] [diff] [review]
patch

i'd just rename this._emptyDefaultBehavior to this._emptySearchDefaultBehavior

since the former is unclear without looking at the definition.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: have empty behavior inherit default behavior

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 399554 [details] [diff] [review]
have empty behavior inherit default behavior

fine for me.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 399554 [details] [diff] [review]
have empty behavior inherit default behavior

r=Mardak

Add tests to test_empty_search:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/autocomplete/test_empty_search.js

You can use the pattern from test_special_search to change the prefs and search.
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/autocomplete/test_special_search.js#166

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: with test

Comment 8

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/f321d600290d

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 399577 [details] [diff] [review]
with test

Want this for Fennec

Comment 10

[[not reading bugmail]]

Is there any change here by using a different number for this pref?

browser.urlbar.default.behavior
1: history
2: bookmarked
4: match tag
8: match title
16: match URL
32: match typed

so you want 1+32 = 33

Comment 11

[:Gavin Sharp [email: [e-mail]]]

I don't understand your comment. The patch uses 33 as a default. That matches the previous behavior.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Yes, changing browser.urlbar.default.behavior to 33 will limit normal awesomebar searches to typed history items, if that's what your asking.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-1.9.2/rev/a5ab7cea34b1