51549 - Find in This Page dialog doesn't automatically get focus when it appears

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[ekrock's old account (dead)]

Using Commercial 2000090508 on WinNT 4.0 SP4.

To repro:
1) Go to cnn.com
2) Search-->Find in This Page

Expected: when the Find in This Page dialog pops up, it will automatically place
focus in its text entry field and user can start typing immediately (the most
reasonable way to design the UE, since if the user chooses Find in This Page, we
know for certain that the next thing they want to do is to be using that
dialog); if there's already previously-searched text in the dialog, it should be
selected to enable easy type-and-replace

Actual: Find in This Page doesn't have focus. User must click in field before
user can begin typing. This imposes an unnecessary extra step on the user.

Comment 1

[ekrock's old account (dead)]

Marking polish and Future since we don't have the time to fix this kind of minor
polish issue for RTM.

Comment 2

[Blake Ross]

I'm absolutely positive this is a dup...but where the hell is it?

Comment 3

[sairuh (rarely reading bugmail)]

i couldn't find (heh) an existing bug like this in xp apps or browser-general.
however, this focus issue i think occurs in other dialogs, eg, open web
location. jrgm, d'you know of a more general bug when focus isn't automatically
give in a dialog?

Comment 4

[Blake Ross]

Got it.  Bug 47507 is for Open Web Location.  Bug 35087 is for the general 
focus problem.  Many of the Find in this Page bugs have been marked dup of 
35087, but that has since been futured (with the workaround being to set focus 
in the onload handler).  47507 has been left open specifically for the Open Web 
Location dialog, so I'll leave this open for the Find dialog.  And I'll work on 
getting it working...

Comment 5

[Blake Ross]

reassigning to me, simple fix

Comment 6

[Blake Ross]

Attachment: patch - also fixes bug 49444

Comment 7

[Blake Ross]

Law - could you please review and then cc brendan for approval on the patch?  
Thanks!

Comment 8

[Blake Ross]

Fix checked in.

Comment 9

[Blake Ross]

*** Bug 52072 has been marked as a duplicate of this bug. ***

Comment 10

[John Morrison]

verified fixed (as I was passing through ...) mac/linux/win32 20000909nn builds
all set initial focus to the text field when the dialog comes up.

Comment 11

[Alexey Chernyak]

This re-appeared for a moment in 2001/4/18 builds, but was fixed the next day.
If this bug ever gets re-opened again, this is a dupe of bug 25271.
There is also a more general bug 35087 which in turn is a subset of bug 58853.
Some related work has been done in bug 63647.