Closed Bug 515551 Opened 10 years ago Closed 10 years ago
_FPU should depend on __i386 __ not __i486 __
I figured that any __GNUC__ compiler generating x87 instructions would define __i486__ -- mine all do -- but I guess I was wrong. If accepted, this patch will fault with an invalid instruction if you try to initialize spidermonkey -- note, spidermonkey itself, not just tracemonkey -- on an x87-less x86 machine. If you can still find one of those, buried in cobwebs. Otherwise it just extends the FIX_FPU clobber to work in cases with surprising compiler definitions.
Attachment #399651 - Flags: review?(brendan)
Comment on attachment 399651 [details] [diff] [review] Enable FIX_FPU instruction sequence anywhere we have __GNUC__ and __i386__ I'm clearly not adding much value here, but r=me. /be
Attachment #399651 - Flags: review?(brendan) → review+
I thought you might care that there's a possibly-new cpu/arch combo that might not start up spidermonkey. If not, I'll carry on.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.