FIX_FPU should depend on __i386__ not __i486__

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: graydon, Assigned: graydon)

Tracking

Trunk
Points:
---
Bug Flags:
wanted1.9.2 +
in-testsuite -

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 399651 [details] [diff] [review]
Enable FIX_FPU instruction sequence anywhere we have __GNUC__ and __i386__

I figured that any __GNUC__ compiler generating x87 instructions would define __i486__ -- mine all do -- but I guess I was wrong.

If accepted, this patch will fault with an invalid instruction if you try to initialize spidermonkey -- note, spidermonkey itself, not just tracemonkey -- on an x87-less x86 machine. If you can still find one of those, buried in cobwebs. Otherwise it just extends the FIX_FPU clobber to work in cases with surprising compiler definitions.
Attachment #399651 - Flags: review?(brendan)
Comment on attachment 399651 [details] [diff] [review]
Enable FIX_FPU instruction sequence anywhere we have __GNUC__ and __i386__

I'm clearly not adding much value here, but r=me.

/be
Attachment #399651 - Flags: review?(brendan) → review+
(Assignee)

Comment 2

9 years ago
I thought you might care that there's a possibly-new cpu/arch combo that might not start up spidermonkey. If not, I'll carry on.
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/tracemonkey/rev/6599bfa8ea11
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/6599bfa8ea11
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2780062a0ce3
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
(Assignee)

Updated

9 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.