Closed
Bug 515565
Opened 16 years ago
Closed 16 years ago
don't unbox all receivers in thunks
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
10.21 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
nativegen.py should have the smarts to know which native thunks need to unbox the receiver (very few) and which don't (almost all), saving an instruction or two from the thunk. the enclosed patch does this. (works with both direct and indirect thunks.)
edwin, if you like the patch, go ahead and land it.
Attachment #399657 -
Flags: review?(edwsmith)
|
Reporter | |
Comment 1•16 years ago
|
||
same as before, but corrected bogus assert in check_unbox
Attachment #399657 -
Attachment is obsolete: true
Attachment #399659 -
Flags: review?(edwsmith)
Attachment #399657 -
Flags: review?(edwsmith)
|
|
||
Updated•16 years ago
|
Attachment #399659 -
Flags: review?(edwsmith) → review+
|
|
Reporter | |
Comment 2•16 years ago
|
||
pushed as changeset: 2503:8f9c50738451
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•