51557 - Turn off the currently active Tab; incorrect text appears

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[verah (gone)]

Steps to reproduce:
(1) Click a My Sidebar Tab, such as What's Related
(2) Open the Tabs menu and remove the checkmark next to "What's Related" in the 
list (i.e., turn the "What's Related" tab off)

Expected behavior: The "What's Related" tab will disappear and the next tab 
that's in My Sidebar will become the active tab.

Actual behavior: The "What's Related" tab disappears, but it is replaced by 
white space and this message: "My Sidebar is currently empty. You may add 
tabs..." etc.

P.S. The message is, of course, incorrect in this context. But if My Sidebar 
really is empty, and the text appears correctly, it is still pretty darned ugly. 
It needs formatting and a couple of hard line breaks!

Comment 1

[verah (gone)]

Nominating for nsbeta3

Comment 2

[verah (gone)]

May be related to 51694.

Comment 3

[Claudius Gayle]

nav traige team:nsbeta3+

Comment 4

[Steve Lamm]

I checked in some code yesterday that may have fixed this. I cannot reproduce 
it today.

Comment 5

[Steve Lamm]

I put in a couple safe guards to avoid this problem. Marking fixed.

Comment 6

[Steve Lamm]

Also, this should work ok in today's build (9/12).

Comment 7

[shrirang khanzode]

On windows, If I uncheck the currently active tab, no incorrect text appears but 
another random panel gets opened. No text appears for that panel unless I click 
on the tab(happens sometimes). I see this on mac too. I am filing a seperate bug 
for that problem and marking this verified since the original bug is fixed. 
(2000091208m18)

Comment 8

[Jesse Ruderman]

new bug = 52660