Closed Bug 515578 Opened 14 years ago Closed 14 years ago

Kill some more xmlextras and webservices leftovers

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

rm
4.12 KB, patch
ted
: review+
Details | Diff | Splinter Review
Attached patch rm — — Splinter Review 
Bug 515130 got rid of the toolkit-makefiles.sh bits that would try to process the makefiles that aren't in extensions/xmlextras and extensions/webservices, which is nice, but if you go to the trouble of defining MOZ_XMLEXTRAS or MOZ_WEBSERVICES in your env (since we won't do it for you in configure), we'll still try to build things that aren't there.
Attachment #399676 - Flags: review?(ted.mielczarek)
Blocks: 515582
Or, alternatively, we should back out bug 515130 - if we actually wanted to make it possible to build either one (with a CVS checkout and an export MOZ_WHICHEVER=1), then there was nothing wrong with those ifdeffed makefiles.
No, we shouldn't keep referencing stuff in our build system because somebody might want to import it from CVS. That's what --enable-extensions is for, or --enable-application, or completely independent projects.
Attachment #399676 - Flags: review?(ted.mielczarek) → review+
Whiteboard: [landme]
Target Milestone: --- → mozilla1.9.3a1
http://hg.mozilla.org/mozilla-central/rev/e9466b0ebc31
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [landme]
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.