515609 - listbox select item on mouse down

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Since bug 510857 has landed, Fabrice has noticed that a mousedown on an item of a richlistbox select the target row :/

After searching a bit I've found that the code which cause this behavior is:
 * http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/listbox.xml#1003

I see 4 workaround:
 1. backout bug 510857 - but we return to unpressed buttons
 2. Prevent the mousedown/mouseup to be dispatched as we use to do before bug 510857 - basically, same as choice 1
 3. Do a binding which override the listitem on our side - crap, we use something unusual
 4. Tweak the listitem binding for avoid this behavior in mobile

Personally i would prefer the last because:
 - I like the idea to dispatched mousedown/mouseup to the world, this way, extension developers can hack around.
 - Usually reacting on mousedown didn't make sense in Fennec

Nit: maybe choice 4 is a bit overkill

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 399764 [details] [diff] [review]
Patch v0.1

Normally, I don't favor overriding toolkit bindings. But this is simple and we really don't want action on mousedown, including drags.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/331cfce379df

Comment 4

[Dão Gottwald [:dao]]

bugspam