515617 - After upgrade to Bugzilla 3.2.4 malformed mails are sent

Status: RESOLVED WORKSFORME

(Bugzilla :: Email Notifications, defect)

Description

[Christian Schlotter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: 

After an upgrade to Bugzilla 3.2.4 malformed mails are sent. In Lotus Notes the emails sent by Bugzilla reach the intended recipient, but the Subject line is empty. Instead the body of the mails starts like this:

<snip>
Subject: [Bug 1234] New: This is a bug description

X-Bugzilla-Reason: CC

X-Bugzilla-Type: newchanged

X-Bugzilla-Watch-Reason: None

X-Bugzilla-Product: A_Product

X-Bugzilla-Component: A_Component

X-Bugzilla-Keywords: 

X-Bugzilla-Severity: major
<snip>
etc.

It seems that all lines are separated by a blank line.

My Bugzilla installation uses ssmtp to send mails. I made sure that the correct versions of needed Perl modules are installed (checksetup output):

Checking for          Email-Send (v2.00)   ok: found v2.190
Checking for          Email-MIME (v1.861)  ok: found v1.863
Checking for Email-MIME-Encodings (v1.313)  ok: found v1.313
Checking for Email-MIME-Modifier (v1.442)  ok: found v1.442
Checking for Email-MIME-Attachment-Stripper (any)     ok: found v1.314
Checking for         Email-Reply (any)     ok: found v1.202

I verified that the ssmtp program is not introducing these empty lines by creating a valid message (text file with To:, Subject: and the body separated by a newfile) and sending it to me with "cat mytextfile | sendmail [e-mail]".

Reproducible: Always

Comment 1

[Christian Schlotter]

Another thing I noticed. The e-mails being sent out contain this at the end:

<snip>
------- You are receiving this mail because: -------


</snip>

In my case there should be "You are on the CC list of this bug." I also made sure that there is no custom template configured instead of email/newchangedmail.txt.tmpl.

Comment 2

[Max Kanat-Alexander]

What version of Template-Toolkit do you have installed? Try updating to 2.22.

Comment 3

[Christian Schlotter]

I had Template-Toolkit 2.19 installed and upgraded to 2.22 now, but it did not change anything.

Comment 4

[Christian Schlotter]

This bug also happens when I upgrade Bugzilla to 3.4.1. The mails have exactly the same problem.

Comment 5

[Christian Schlotter]

Attachment: checksetup output

Please find attached the output of checksetup.pl. I'm attaching it to show the version numbers of the packages relative to Bugzilla.

Comment 6

[Christian Schlotter]

I fixed the problem for me on Bugzilla 3.2.4 and 3.4.1 by commenting out the line in Mailer.pm which converts CR+ LF to CR LF[1].

[1] http://mxr.mozilla.org/mozilla/source/webtools/bugzilla/Bugzilla/Mailer.pm#76

Comment 7

[Christian Schlotter]

My change in comment #6 does not fix the repeating "Your Bugzilla bug list needs attention" emails. It still has too many line breaks in the body (the header seems to be OK) and starts like this:

<snip>
[This e-mail has been automatically generated.]



You have one or more bugs assigned to you in the Bugzilla bug tracking syst
em (http://bugzilla/) that require

attention.



All of these bugs are in the NEW orREOPENED state, and have not been

touched in 7 days or more.

You need to take a look at them, and decide on an initial action.



Generally, this means one of three things:



(1) You decide this bug is really quick to deal with (like, it's INVALID),

    and so you get rid of it immediately.

(2) You decide the bug doesn't belong to you, and you reassign it to

    someone else. (Hint: if you don't know who to reassign it to, make

    sure that the Component field seems reasonable, and then use the

    "Reassign bug to default assignee of selected component" option.)

(3) You decide the bug belongs to you, but you can't solve it this moment.

    Just use the "Accept bug" command.
</snip>

I cannot test at the moment if my change mentioned in comment #6 introduced this behavior.

Comment 8

[Max Kanat-Alexander]

Are you running under mod_perl? Have you restarted httpd since these updates?

Comment 9

[bigstijn]

Max, sure this is the right duplicate ?

Comment 10

[Max Kanat-Alexander]

(In reply to comment #9)
> Max, sure this is the right duplicate ?

  Mmmm, pretty much, because the summary says "after 3.2.4 upgrade".

Comment 11

[Christian Schlotter]

(In reply to comment #8)
> Are you running under mod_perl? Have you restarted httpd since these updates?

I'm not running under mod_perl and have restarted lighttpd and the whole server since these updates.

(In reply to comment #10)
> (In reply to comment #9)
> > Max, sure this is the right duplicate ?
> 
>   Mmmm, pretty much, because the summary says "after 3.2.4 upgrade".

But I also upgraded to 3.4.1 and the bug remained the same! Uncommenting the line mentioned in comment #6 also fixed the problem for me on 3.4.1.

Given that Bugzilla 3.4.1 was released after bug 469794 was resolved, I'm reopening this bug.

If needed I can help to debug this problem as I have a virtual machine image with Bugzilla 3.4.1 which shows the reported bug.

Comment 12

[Max Kanat-Alexander]

(In reply to comment #11)
> I'm not running under mod_perl and have restarted lighttpd and the whole server
> since these updates.

  lighttpd could be the problem, too--we don't actually officially support it. Do you have the same problem under an Apache mod_cgi configuration?

> But I also upgraded to 3.4.1 and the bug remained the same! Uncommenting the
> line mentioned in comment #6 also fixed the problem for me on 3.4.1.

  Uncommenting, or commenting? Because that line is not commented-out by default.

> Given that Bugzilla 3.4.1 was released after bug 469794 was resolved, I'm
> reopening this bug.

  No, *3.4.2* was released afterward, not 3.4.1.

  I'd suggest just commenting before reopening, instead of reopening directly. I respond on closed bugs just as well as I respond on open bugs.

Comment 13

[Max Kanat-Alexander]

(In reply to comment #12)
>   No, *3.4.2* was released afterward, not 3.4.1.

  Oh wait, nevermind, you were right. I was looking at the changes on the 3.2 branch, not on the 3.4 branch.

Comment 14

[Christian Schlotter]

(In reply to comment #12)
>   lighttpd could be the problem, too--we don't actually officially support it.
> Do you have the same problem under an Apache mod_cgi configuration?

Unfortunately I cannot test under Apache.

(In reply to comment #12)
> (In reply to comment #11)
> > But I also upgraded to 3.4.1 and the bug remained the same! Uncommenting the
> > line mentioned in comment #6 also fixed the problem for me on 3.4.1.
>   Uncommenting, or commenting? Because that line is not commented-out by
> default.

Commenting, sorry.

Comment 15

[Frédéric Buclin]

Per bug 415529, there are problems using lighttpd with Bugzilla, so unless you can reproduce this problem with Apache, this bug is WFM/invalid.