Closed
Bug 515620
Opened 16 years ago
Closed 16 years ago
Set up default SHOWFOR for Fennec branch
Categories
(support.mozilla.org :: Mobile, task)
support.mozilla.org
Mobile
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: laura, Assigned: jsocol)
Details
Attachments
(1 file)
9.30 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
From David's email:
After a chat with Stuart, we basically agreed to be using SHOWFOR in a somewhat simplified way compared to how we do it on Desktop Firefox: they will only be using the "operating system" field and use that for their respective platform/devices.
This may change in the future, but for now this is what we agreed on, and it seems fine for the first 6 months at least.
Platforms: 'N810' 'N900' 'Windows Mobile'
Suggested "variables": n810, n900, winmo
Updated•16 years ago
|
Summary: Setup default SHOWFOR for Fennec branch → Set up default SHOWFOR for Fennec branch
Assignee | ||
Comment 1•16 years ago
|
||
As part of this, we should move the detection script (showfor.js) into a .dist file and come up with a version for Fennec. Productizing the current detection implementation is nontrivial. Maybe after setting up a second one we'll have a better sense of how to do it.
Reporter | ||
Comment 2•16 years ago
|
||
We also need some direction on user agent detection here from Stuart (waiting on email response) and what the default user agent should be.
Assignee | ||
Comment 3•16 years ago
|
||
Without knowing the details of platform detection, this is just a first pass, but I created a new showfor/config.php.dist-fennec which has the N810/N900/WinMo operating systems and no versions, as well as made a guess at how platform detection will work in the new webroot/js/wikiplugin_showfor.js.dist-fennec.
I moved the default wikiplugin_showfor.js to wikiplugin_showfor.js.dist and added instructions to the Installing SUMO wiki page.
Attachment #401082 -
Flags: review?(laura)
Reporter | ||
Updated•16 years ago
|
Attachment #401082 -
Flags: review?(laura) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
Can this be verified, yet? (Judging by comment 3, I'm thinking not, but if so, I'll jump on it.)
You need to log in
before you can comment on or make changes to this bug.
Description
•