If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[faceted search]: allow the timeline to be collapsed (and remember it)

RESOLVED FIXED in Thunderbird 3.0b4

Status

Thunderbird
Search
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: davida, Assigned: davida)

Tracking

Trunk
Thunderbird 3.0b4
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [no l10n impact])

Attachments

(2 attachments, 5 obsolete attachments)

(Assignee)

Description

8 years ago
The timeline has been heard described as "info-porn".  IOW, while fun and pleasing and sometimes useful, it's maybe not always that essential, and some people may not value it enough to give it prime above-the-fold space all the time.

One idea is to have a toggle feature (glyph, words, whatever) that allows one to collapse the toolbar to use a very small amount of space (maybe 0 vertical space), and persist that choice across queries.
Flags: blocking-thunderbird3?
We should probably also add the "zoom out" affordance at the same time... right now, once you select a time range, there's no/limited going back.  (You can get back out to the year because it is displayed, but you can't zoom out further than that.)
Created attachment 399877 [details]
timeline hide mockup

I think if we offer the timeline as a button off to the right where we grow the space for the widget people can show / hide it as needed.
(Assignee)

Comment 3

8 years ago
Created attachment 400054 [details] [diff] [review]
wip
Assignee: nobody → david.ascher
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Whiteboard: [has l10n impact]
Target Milestone: --- → Thunderbird 3.0rc1
(Assignee)

Comment 4

8 years ago
Created attachment 400241 [details] [diff] [review]
patch v1

This works for me.  I made up the icon from your mockup, and I didn't make the borders, for a variety of reasons (hard to figure out how to deal with wide windows elegantly, not sure we want that bold a border, didn't know if you just wanted the border on hover, etc.).

I think the code review and ui review can be quite parallel here.
Attachment #400054 - Attachment is obsolete: true
Attachment #400241 - Flags: ui-review?(clarkbw)
Attachment #400241 - Flags: review?(bugmail)
(Assignee)

Updated

8 years ago
Whiteboard: [has l10n impact] → [no l10n impact][has patch, needs review asuth, ui-review clarkbw]
Comment on attachment 400241 [details] [diff] [review]
patch v1

= UI input, yielding to clarkbw where there is debate:

The hovered timeline has no whitespace between it and the AND/OR toggle button.  I think there should be.

I find the animation effect's involvement of the x-axis distracting.  I think a vertical rollup would be more straightforward.

= Logic

The timeline widget's state is inconsistent when initialized collapsed.  It is hidden, but _timelineShown is never set to false, so the next time you try and toggle it, you're just hiding it again.

I would suggest losing the ugly preference branch boilerplate and just using Application.prefs intead:
https://developer.mozilla.org/en/Toolkit_API/extIPreferenceBranch

r=asuth with the logic changes, UI changes at your/clarkbw's discretion.
Attachment #400241 - Flags: review?(bugmail) → review+
Status: NEW → ASSIGNED
Whiteboard: [no l10n impact][has patch, needs review asuth, ui-review clarkbw] → [no l10n impact][has patch, needs ui-review clarkbw]
(Assignee)

Comment 6

8 years ago
Created attachment 400336 [details] [diff] [review]
revised patch

fixed the logic & code bugs.
dealt with the overlap w/ the and/or box.
I can't repro any horizontal animation, so I'm a bit stumped w/ that one.
Attachment #400241 - Attachment is obsolete: true
Attachment #400336 - Flags: ui-review?(clarkbw)
Attachment #400336 - Flags: review+
Attachment #400241 - Flags: ui-review?(clarkbw)
(Assignee)

Comment 7

8 years ago
Created attachment 400538 [details] [diff] [review]
fixed patch

fixed the horizontal glitch (having to do w/ style tweaks happening on slideUp, and margins), centered the timeline within the 'results' column, and changed the sizing process for the timeline to work even when 'hidden' therefore avoiding rebuild on toggling.
Attachment #400336 - Attachment is obsolete: true
Attachment #400538 - Flags: ui-review?(clarkbw)
Attachment #400538 - Flags: review?(bugmail)
Attachment #400336 - Flags: ui-review?(clarkbw)
Attachment #400538 - Flags: review?(bugmail) → review+
Comment on attachment 400538 [details] [diff] [review]
fixed patch

this patch failed to apply for me
Whiteboard: [no l10n impact][has patch, needs ui-review clarkbw] → [no l10n impact][needs updated patch]
(Assignee)

Comment 9

8 years ago
Created attachment 400560 [details] [diff] [review]
De-bitrotted patch

debitrotted
Attachment #400538 - Attachment is obsolete: true
Attachment #400560 - Flags: ui-review?(clarkbw)
Attachment #400560 - Flags: review+
Attachment #400538 - Flags: ui-review?(clarkbw)
Attachment #400560 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 400560 [details] [diff] [review]
De-bitrotted patch

just change the pref to default to the timeline being collapsed.  ui-r+ with that
(Assignee)

Comment 11

8 years ago
Created attachment 400562 [details] [diff] [review]
patch w/ other pref value

your wish is my command.
Attachment #400560 - Attachment is obsolete: true
Attachment #400562 - Flags: ui-review+
Attachment #400562 - Flags: review+
Attachment #400562 - Flags: approval-thunderbird3?
Attachment #400562 - Flags: approval-thunderbird3? → approval-thunderbird3+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [no l10n impact][needs updated patch] → [no l10n impact]
Checked in: http://hg.mozilla.org/comm-central/rev/bba60b936b03
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b4
Component: Mail Window Front End → Search
QA Contact: front-end → search

Comment 13

8 years ago
It not really nice for .css living in /content/ to refer to images living in /skin/. One should really define the style rules that refer to images in /skin/ in .css living in /skin/.
You need to log in before you can comment on or make changes to this bug.