51570 - ctrl+W doesn't close the editor window

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[sairuh (rarely reading bugmail)]

i only see this on linux [2000.09.05.04, opt comm]; not a problem on mac or
winnt. saari, not sure if this should go to you, or someone in the editor group
(reassign as needed).

1. start the browser.
2. select tasks > composer to bring up editor window.
3. bring focus to editor window (eg, click in the content).
4. try to close using the shortcut, ctrl+W (ctrl is the default accelerator
here).

result: the editor window doesn't close. get the following console errors:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIController.doCommand]"  nsresult:
"0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: <unknown
filename> :: onkeypress :: line 0"  data: no]

Comment 1

[Akkana Peck]

Chris: This might be due to the conflict between XBL and XUL key bindings
(there's a ^W in each set on Unix, and in fact there may be a xul binding with
xulkey= and a xul binding with control=, so there is one conflict and perhaps
two).  Which one should take precedence, and has there been a recent change in
the precedence order?

The conflicting binding should perhaps be removed -- it makes sense with
xulkey=alt but not with xulkey=control -- but many users will want to put it
back, so we still need to know the expected behavior here.  So this is probably
my bug, but I need to know something about how it should work in order to know
the best way to fix it.

Comment 2

[Peter Trudelle]

saari is on vacation this week.

Comment 3

[Peter Trudelle]

->wfm. akkana, did you fix this?

Comment 4

[Akkana Peck]

Not knowingly.  But there were some other things horked about key bindings, so
maybe my general key binding patch helped this.

Comment 5

[sairuh (rarely reading bugmail)]

still a problem for me using 2000.09.13.08 opt comm bits. reopening.

Comment 6

[Peter Trudelle]

->akkana, per saari

Comment 7

[Akkana Peck]

Oh, actually, the problem here is the conflict between the emacs editing
bindings and the window bindings, now that control is the default modifier.

I guess we need to take ^W out of the list of platform editing bindings.

This is trivial and I've done it in my tree.  We might as well get it in for
beta.  

Comment 8

[kinmoz]

Marking nsbeta3+ in beppe's absence.

Comment 9

[Akkana Peck]

Fixed.  We'll have to do without ^W in editor/mail compose windows, alas.

Comment 10

[sairuh (rarely reading bugmail)]

thx, akkana! works fine using 2000.09.15.08 on linux [opt comm]... other than
that other problem with bug 52808. ;)