515723 - [faceted search] glodaFacetView.facets.mode.top.moreLabel should support plurals

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Here's an excerpt from current glodaFacetView.properties :

# LOCALIZATION NOTE (glodaFacetView.facets.mode.top.moreLabel): The label to
#  use when we are only displaying the top entries for a facet.  When the
#  label is clicked on, it results in us displaying all of the values for that
#  facet.  The value "#1" (if present) is replaced with the total number of
#  values that will be displayed (rather than the number currently hidden).
glodaFacetView.facets.mode.top.moreLabel=List all #1

Please add plural support to this string to make it easier to localize.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: add pluralization to the more label v1

As I was saying on the other bug, I hope this should be okay to land because it is backwards compatible.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: we need to specify all plural forms; this is not backwards compatible.

PluralForm.jsm was complaining but doing what I wanted.  I had not noticed the complaining.  We must provide all the pluralizations demanded by our locale, so this we do.  This makes the change non-backwards-compatible, and additionally means I had to rename the string.  Ugh.

I suppose we should target this at rc1?

Comment 3

[Simon Paquet [:sipaq]]

I agree, we have two weeks after the b4 release for additional string changes before we freeze strings once and for all. This seems suitable for that period.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

pushed:
http://hg.mozilla.org/comm-central/rev/0f0702b3c490