515737 - on latest trunk build, side bars extend past bottom of maemo screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on the latest nightly trunk build for maemo, my side bars (tab + button and options button) are slightly off the bottom of the screen.

In the case of the options button, once clicking on it, the options pages look normal, but when viewed as a sidebar, it is too low.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

see: http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-n900-leftside.png

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

probably my bad - (it seems to be a recurrent stuff these days) with the landing of bug 511493.

/me looking

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

i don't have a n900 to test it but these lines can be responsible of it : tabs.xml#115

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

this is an issue on the n810 and n900 for 1.9.2 as well.  This means that links at the bottom of a webpage cannot be clicked.  for example.
m.facebook.com has a "logout" link at the very bottom and I have no way to click that.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This should work better - but I still need to test it on my device.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 401234 [details] [diff] [review]
Patch

Ok. It looks to work well on my device.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 401234 [details] [diff] [review]
Patch

Change "BrowserUI.toolbarH" to "container.top"

I'll do that when I land it

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/0c2fc77506c4

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

verified on my n810 with 20090921 1.9.2 nightly build