515758 - URLBar does not switch back to title when dismissing bookmark list

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

* Click into URLbar
* Choose "Show all bookmarks"
* Dismiss using the "^" button
* URLbar is still showing the URL not the title

The URLbar should be showing the webpage title

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Yep these lines of bindings.xml are always false, that's the problem i supposed

359           if (originalTarget == this._allBookmarksItem ||
360               target == this._allBookmarksItem) {

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Mark, thanks for the idea of calling this.close();

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 400020 [details] [diff] [review]
Patch

hmm, changing the closePopup() to close() in the "blur" handler is breaking the awesomebar

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Yeah, the close reset the value to the default, this should work now.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 400025 [details] [diff] [review]
Patch v0.2

I will tweak "blur" check so we don't get the reportError fired for "blur" in any situation

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with tweaks:
https://hg.mozilla.org/mobile-browser/rev/8a19db84b48c

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090914
Fennec/1.0b4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090914
Fennec/1.0a3

Comment 8

[Dão Gottwald [:dao]]

bugspam