Closed Bug 515758 Opened 10 years ago Closed 10 years ago

URLBar does not switch back to title when dismissing bookmark list

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

* Click into URLbar
* Choose "Show all bookmarks"
* Dismiss using the "^" button
* URLbar is still showing the URL not the title

The URLbar should be showing the webpage title
tracking-fennec: --- → ?
Yep these lines of bindings.xml are always false, that's the problem i supposed

359           if (originalTarget == this._allBookmarksItem ||
360               target == this._allBookmarksItem) {
Attached patch Patch (obsolete) — Splinter Review
Mark, thanks for the idea of calling this.close();
Attachment #400020 - Flags: review?(mark.finkle) → review+
Comment on attachment 400020 [details] [diff] [review]
Patch

hmm, changing the closePopup() to close() in the "blur" handler is breaking the awesomebar
Attachment #400020 - Flags: review+ → review-
Attached patch Patch v0.2Splinter Review
Yeah, the close reset the value to the default, this should work now.
Attachment #400020 - Attachment is obsolete: true
Attachment #400025 - Flags: review?(mark.finkle)
Comment on attachment 400025 [details] [diff] [review]
Patch v0.2

I will tweak "blur" check so we don't get the reportError fired for "blur" in any situation
Attachment #400025 - Flags: review?(mark.finkle) → review+
pushed with tweaks:
https://hg.mozilla.org/mobile-browser/rev/8a19db84b48c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090914
Fennec/1.0b4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090914
Fennec/1.0a3
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
bugspam
Assignee: nobody → 21
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.