Closed
Bug 515760
Opened 15 years ago
Closed 15 years ago
[faceted search]: attachment display is clipped
Categories
(Thunderbird :: Search, defect)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: tessarakt, Assigned: davida)
Details
(Keywords: polish, Whiteboard: [no l10n impact])
Attachments
(3 files)
|
46.31 KB,
image/png
|
Details | |
|
356 bytes,
patch
|
clarkbw
:
review+
clarkbw
:
ui-review+
|
Details | Diff | Splinter Review |
|
471 bytes,
patch
|
davida
:
review+
|
Details | Diff | Splinter Review |
icon and text are clipped
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5b4pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090910 Lightning/1.0pre Shredder/3.0b4pre Search for a term where you will find a message with an attachment. In the entry for that message, the paper-clip and the line of text next to it is clipped vertically. (See attached image - I deleted some personal data, but the clipping mentioned above appears just like that.) Reproducible: Always
|
Reporter | |
Comment 1•15 years ago
|
||
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → david.ascher
Flags: blocking-thunderbird3+
Keywords: polish
OS: Windows XP → All
Hardware: x86 → All
|
||
Updated•15 years ago
|
Whiteboard: [no l10n impact]
|
|
Assignee | |
Comment 2•15 years ago
|
||
The max-height was setup for the case of 10's of recipients, which was bad. now we have "and N more", so the recipient div never gets too big. We could still have lots of attachments, so I'm keeping a max-height, but making it big enough that it won't affect 99.999% of messages. We probably want some "and N more" code for large numbers of attachments, but that probably doesn't block TB3, while this does IMO.
Attachment #400102 -
Flags: ui-review?(clarkbw)
Attachment #400102 -
Flags: review?(clarkbw)
|
|
Assignee | |
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [no l10n impact] → [no l10n impact][has patch needs review clarkbw]
Target Milestone: --- → Thunderbird 3.0b4
|
||
Comment 3•15 years ago
|
||
Comment on attachment 400102 [details] [diff] [review] patch agreed, this tends to work 99% better for most of my messages. I have another patch to go along with this as I couldn't see the icon in linux.
Attachment #400102 -
Flags: ui-review?(clarkbw)
Attachment #400102 -
Flags: ui-review+
Attachment #400102 -
Flags: review?(clarkbw)
Attachment #400102 -
Flags: review+
|
|
||
Comment 4•15 years ago
|
||
bouncing back to davida for a patch review on this since you likely know it better than anyone else.
Attachment #400120 -
Flags: review?(david.ascher)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 400120 [details] [diff] [review] recover for the lack of icons/attachment.png in gnomestripe looks fine.
Attachment #400120 -
Flags: review?(david.ascher) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [no l10n impact][has patch needs review clarkbw] → [no l10n impact][needs approval]
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [no l10n impact][needs approval] → [no l10n impact]
|
||
Comment 6•15 years ago
|
||
Both patches checked in: http://hg.mozilla.org/comm-central/rev/227e8349ba4d http://hg.mozilla.org/comm-central/rev/b1b4d0b788dd
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Component: Mail Window Front End → Search
QA Contact: front-end → search
You need to log in
before you can comment on or make changes to this bug.
Description
•