515761 - URLBar textbox will auto capitalize on n900

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We should find a way to not auto-captialize the first letter on certain textboxes. Other options include: disable the feature for all of Fennec (not desirable) or even have the user turn it off for the entire device (not acceptable)

See http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-n900-entering-url.png

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

there is a setting in the settings->text input to turn this off.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> there is a setting in the settings->text input to turn this off.

There i a setting, but we should not force people to use it. Some textboxes are perfect candidates for auto-capitalize. Others are not.

Comment 3

[Aakash Desai [:aakashd]]

is this something we should relnote?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch simply turns off the auto-capitalize feature for all input boxes

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 402687 [details] [diff] [review]
patch

> // Turn off auto-captitalization for editboxes

"capitalization", otherwise, looks ok.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/66987a7cf40c

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/37595a72841c

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre