515801 - [faceted search]: cross-platform styling improvements on results page

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[David Ascher (:davida)]

Attachment: bare bones improvements for the "list all N" div

We're going to need to make a bunch of css and layout changes to the results page.  I propose that we use this bug as a place to throw up patches to improve the polish.

first patch: make the 'list all' not as ugly, and tweak some cursor: lines, although it's still a mess.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 399856 [details] [diff] [review]
bare bones improvements for the "list all N" div

looks better! just move the "cursor: pointer;" into the .facet-more selector from the :hover selector.  ui-r+ with that.

Comment 2

[David Ascher (:davida)]

Attachment: [checked in] updated patch

Given that this is just a fairly trivial CSS change, I'm going to take clarkbw's review as both ui-r= and r= ask standard8 to confirm this assessment through the approval flag.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 400086 [details] [diff] [review]
[checked in] updated patch

Well I'm not sure you meant sr ;-) so

r+ui-r=clarkbw,a=Standard8.

Comment 4

[David Ascher (:davida)]

Overall this needs to be done by rc1, but we will try and get some small safe changes into b4.  I don't think we have anything that blocks b4.

Comment 5

[Rain [:rain1] (inactive)]

Comment on attachment 400086 [details] [diff] [review]
[checked in] updated patch

http://hg.mozilla.org/comm-central/rev/67a4727976ab

Comment 6

[Ilja Sekler]

Attachment: No gap between attachments

If attachments have very short names so that two of them fit into one line, there is no gap between them now. Even if is rather a rare case, maybe it is worth of providing a margin (or padding) to .message-attachment in glodaFacetView.css?

Comment 7

[David Ascher (:davida)]

Attachment: css tweak to split up attachments

Here's a fix for the "no gap between attachments", that assumes that we can use commas across locales.  If that's an issue, we could do a version without commas and with just whitespace, but it looks a bit off IMO.  We could use en-dashes, or even fancier glyphs.  Diminishing returns at some point...

Comment 8

[David Ascher (:davida)]

(aside, from https://bugzilla.mozilla.org/show_bug.cgi?id=515998#c7 by Pike, it sounds like we have a little bit of leeway on these kinds of listings as they don't really act like natural language -- which I guess I knew given my alternative suggestions in comment #7)

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 401944 [details] [diff] [review]
css tweak to split up attachments

I'm not sure why you have the :first-child:before rule as the :after + :last-child:after should handle this.

In terms of the UI this looks fine.

Comment 10

[Ilja Sekler]

Attachment: alignment comparison

> +  -moz-padding-end: 1ex;

I'm very sorry for the spam, but IMVHO -moz-padding-start would look nicer, because it doesn't break the alignment to the right and gives the attachment icon some space to live.

The left screenshot has been taken from a build with the original patch, the right one with -moz-padding-start.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #10)
> I'm very sorry for the spam, but IMVHO -moz-padding-start would look nicer,
> because it doesn't break the alignment to the right and gives the attachment
> icon some space to live.

This change sounds good to me.  Thanks!

Comment 12

[David Ascher (:davida)]

Attachment: with padding-start

carrying forward reviews, based on bug comments.

Comment 13

[Ilja Sekler]

(In reply to comment #12)
> Created an attachment (id=403258) [...]
> with padding-start

I'm sorry, maybe I'm missing something, but this patch and the obsoleted one with padding-end are identical.

Comment 14

[David Ascher (:davida)]

Attachment: the right patch

thanks for the catch.  attached the right filename, but from the wrong directory

Comment 15

[David Ascher (:davida)]

Attachment: the righter patch

also take care of bryan's earlier comment

Comment 16

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/b95d71a887f0

Comment 17

[Ilja Sekler]

Attachment: Overlapping text and other remaining problems with attachments

Phil, David, would you prefer to reopen this bug to treat the remaining issues like odd line-breaks and overlapping or truncated attachment names here or should I file a followup bug?

Comment 18

[David Ascher (:davida)]

Let's make a new bug, with a clearer description than what I used for this one.

Comment 19

[Ilja Sekler]

(In reply to comment #18)
> Let's make a new bug, with a clearer description than what I used for this one.

Filed <https://bugzilla.mozilla.org/show_bug.cgi?id=519809>.