TM: add a way to flush CodeAllocs without deleting/recreating [nanojit]

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
VMAllocators can already do this.
(Assignee)

Comment 1

9 years ago
Created attachment 399960 [details] [diff] [review]
patch
Assignee: general → gal
(Assignee)

Updated

9 years ago
Attachment #399960 - Flags: review?(graydon)

Updated

9 years ago
Attachment #399960 - Flags: review?(graydon) → review+
Code looks fine and harmless, may as well.

Odd though, is this needed for making Assemblers short-lived? I'd have thought the opposite: that making them short-lived would *remove* the need for any kind of reset function (which plainly we're making-do without, presently).
(Assignee)

Comment 3

9 years ago
The assembler and filter create temporary data, which we will allocate from a tempAlloc in the compiler (TraceRecorder and NativeRegExpCompiler). There the allocator will simply be destroyed. For the dataAlloc (currently allocator) and codeAlloc we can use reset().
(Assignee)

Updated

9 years ago
Summary: add a way to flush CodeAllocs without deleting/recreating [nanojit] → TM: add a way to flush CodeAllocs without deleting/recreating [nanojit]
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/tracemonkey/rev/01fc5bf1d21a
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/01fc5bf1d21a
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.