51608 - File with non-ascii name doesn't get attached

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P2)

Description

[marina]

Steps to reproduce:
- open New Mail Composition;
- click on the Attach icon, browse for the file with non-ascii name;
//note: in the attachment pane nothing shows up
//when you'll get the mail you'll equaly see that the body is blank and no 
attachment envelope is displayed

Comment 1

[R.K.Aa.]

dup of bug 43689?

Comment 2

[marina]

this bug has nothing to do with 43689. There the attachment is getting sent but 
has display problems , in this case it is not sent out at all

Comment 3

[nhottanscp]

CC to alecf, ducarroz, jefft.
It dumps on my debug build as following.
One thing I see is that the file name is not encoded in UTF-8 but used OS 
charset (windows-1252 in my case).
I cannot reproduce this with PR2.

AttachFile()
nsIFilePicker - file:///D:/%80%80%80.txt
************************************************************
** NOTE: This report will only be printed in DEBUG builds.**
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[Exception... "Unexpected error"  code: "-2147418113" nsresult: "
0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "chrome://messenger/content/messeng
ercompose/MsgComposeCommands.js Line: 1369"] [nsIController::doCommand]"  nsresu
lt: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: chrom
e://global/content/globalOverlay.js :: goDoCommand :: line 73"  data: no]
************************************************************
An error occurred executing the cmd_attachFile command

Comment 4

[Jean-Francois Ducarroz]

it's maybe a problem related to the use of the new file picker (nsIFilePicker) 
varada make the change for few weeks ago.

Comment 5

[nhottanscp]

Setting 8 bit string to tooltip causes an error. In MsgComposeCommands.js,
cell.setAttribute("tooltiptext", unescape(attachment)); 

We can avoid the error by not unescaping for the tooltip and that fixes this 
bug.
We need more investigation to show escaped url correctly for tooltip (but that 
is lower priority).

Comment 6

[Jean-Francois Ducarroz]

Noaki, you should try this:

try { 
      cell.setAttribute("tooltiptext", unescape(attachment)); 
      } catch (e) {cell.setAttribute("tooltiptext", attachment)} 

Comment 7

[Frank Tang]

I think this is serious enough to be nsbeta3+ P2

Comment 8

[nhottanscp]

Jean-Francois's patch fixed the problem, thanks.
I checked in the patch.
Because 8 bit file names are not unescaped with this patch, tooltip shows 
escaped file name for 8 bit file names. I will file a separate bug. 

Comment 9

[Katsuhiko Momoi]

To marina for verification. Thanks.

Comment 10

[marina]

verified with 2000-09-14 build, i don't see it happening anymore.

Comment 11

[Jean-Francois Ducarroz]

*** Bug 52697 has been marked as a duplicate of this bug. ***