Closed
Bug 516302
Opened 15 years ago
Closed 14 years ago
nsWifiMonitor::DoScan spins in a tight loop on error
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kinetik, Assigned: dougt)
References
()
Details
Attachments
(1 file)
|
893 bytes,
patch
|
blassey
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
If WirelessScanSplit returns an error (which happens if wifi is disabled), DoScan() spins in a tight loop until it's killed by its owner setting mKeepGoing to PR_FALSE. This might also happen with wifi enabled if WirelessScanSplit returns a null managed_access_points, but it seems just as likely it'd return a zero sized CFArray in that case. To test: turn off wifi via the menubar, then try to use geolocation. The scanner thread spins using 100% CPU for 5 seconds before a timer fires and kills off the scan.
|
Assignee | |
Updated•15 years ago
|
Summary: OS X version of nsWifiMonitor::DoScan spins in a tight loop on error → [10.6] nsWifiMonitor::DoScan spins in a tight loop on error
|
|
Assignee | |
Updated•15 years ago
|
Summary: [10.6] nsWifiMonitor::DoScan spins in a tight loop on error → nsWifiMonitor::DoScan spins in a tight loop on error
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → doug.turner
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #470828 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #470828 -
Flags: review? → review?(blassey.bugs)
|
||
Updated•14 years ago
|
Attachment #470828 -
Flags: review?(blassey.bugs) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #470828 -
Flags: approval2.0?
|
|
Assignee | |
Comment 2•14 years ago
|
||
risk/reward: this basically just prevents us from busy waiting for 5s if wifi is off. it is very safe.
|
||
Updated•14 years ago
|
Attachment #470828 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c6ca51771894
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•