Closed Bug 516571 Opened 10 years ago Closed 10 years ago

search button bustage

Categories

(Firefox for Android Graveyard :: General, defect, blocker)

All
Windows Mobile 6 Professional
defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b4

People

(Reporter: dougt, Assigned: vingtetun)

Details

Attachments

(1 file)

click in the url bar
type a search term (I typed "fff")
click on the google button

Expected result:

a search to be performed using google

Actual result:

The awesome bar results disappear and the URL bar changes back to the original page
Flags: wanted-fennec1.0?
Breakage caused by bug 515683, which changed an onmousedown to an onclick. For some reason, onclick and oncommand don't seem to work.
tracking-fennec: --- → ?
(In reply to comment #1)
> Breakage caused by bug 515683, which changed an onmousedown to an onclick. For
> some reason, onclick and oncommand don't seem to work.

Yep, I've worked a bit on it yesterday, the true problem is that during the dispatching of mousedown we hit the "blur" event of the popup_autocomplete which close the awesome bar!

Coming back soon with a patch
Attached patch PatchSplinter Review
I'm not sure that using moz-user-focus: ignore is the right way...

I'm wondering also why we need the close call for the click?
Comment on attachment 400721 [details] [diff] [review]
Patch

>+    // we don't want button to look pressed for now
>+    button.parentNode.selectedItem = null;
>+

Actually, this would be a good thing. I'll remove that before landing.
Attachment #400721 - Flags: review+
pushed with tweak:
https://hg.mozilla.org/mobile-browser/rev/14acfc47dfcf
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
The verification of this bug is dependent (at least for me) on bug 516963 and bug 514056
verified on my n810 with 20090921 1.9.2 nightly build.  Aakash, I am not marking as "verified" as you had some reservations in comment #6.
Well, after playing around with the UI a bit, I was able to verify on winmo:


Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

Those other two bugs really need to get fixed though.
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Flags: wanted-fennec1.0?
There's a testcase for this on litmus, but we need to make sure all the expected results are accounted for.
Flags: in-litmus?
litmus test case id's 9783-9786 have been created to regression test this bug.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.