516571 - search button bustage

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

click in the url bar
type a search term (I typed "fff")
click on the google button

Expected result:

a search to be performed using google

Actual result:

The awesome bar results disappear and the URL bar changes back to the original page

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Breakage caused by bug 515683, which changed an onmousedown to an onclick. For some reason, onclick and oncommand don't seem to work.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Breakage caused by bug 515683, which changed an onmousedown to an onclick. For
> some reason, onclick and oncommand don't seem to work.

Yep, I've worked a bit on it yesterday, the true problem is that during the dispatching of mousedown we hit the "blur" event of the popup_autocomplete which close the awesome bar!

Coming back soon with a patch

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I'm not sure that using moz-user-focus: ignore is the right way...

I'm wondering also why we need the close call for the click?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 400721 [details] [diff] [review]
Patch

>+    // we don't want button to look pressed for now
>+    button.parentNode.selectedItem = null;
>+

Actually, this would be a good thing. I'll remove that before landing.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with tweak:
https://hg.mozilla.org/mobile-browser/rev/14acfc47dfcf

Comment 6

[Aakash Desai [:aakashd]]

The verification of this bug is dependent (at least for me) on bug 516963 and bug 514056

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

verified on my n810 with 20090921 1.9.2 nightly build.  Aakash, I am not marking as "verified" as you had some reservations in comment #6.

Comment 8

[Aakash Desai [:aakashd]]

Well, after playing around with the UI a bit, I was able to verify on winmo:


Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

Those other two bugs really need to get fixed though.

Comment 9

[Aakash Desai [:aakashd]]

There's a testcase for this on litmus, but we need to make sure all the expected results are accounted for.

Comment 10

[Aakash Desai [:aakashd]]

litmus test case id's 9783-9786 have been created to regression test this bug.