516644 - Bogus asserts in imgRequestProxy::LockImage

Status: RESOLVED DUPLICATE of bug 516335

(Core :: Graphics: ImageLib, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk debug build

STEPS TO REPRODUCE:
1)  Run reftest
2)  Have the run fail due to this:

  NS_ABORT_IF_FALSE(!mLockHeld, "Only call lockImage once per imgIRequest!");

with a stack something like:

#6  0x00582007 in NS_DebugBreak_P (aSeverity=3, aStr=0x13828ce8 "Only call lockImage once per imgIRequest!", aExpr=0x13828cdb "!mLockHeld", aFile=0x13828a40 "/Users/bzbarsky/mozilla/css-frameconst/mozilla/modules/libpr0n/src/imgRequestProxy.cpp", aLine=299) at /Users/bzbarsky/mozilla/css-frameconst/mozilla/xpcom/base/nsDebugImpl.cpp:321
#7  0x137e8f62 in imgRequestProxy::LockImage (this=0x1d7ec090) at /Users/bzbarsky/mozilla/css-frameconst/mozilla/modules/libpr0n/src/imgRequestProxy.cpp:299
#8  0x11dddf81 in nsStyleBorder::SetBorderImage (this=0x22d77c10, aImage=0x1d7ec090) at nsStyleStructInlines.h:61
#9  0x11dd05f8 in nsRuleNode::ComputeBorderData (this=0x24879490, aStartStruct=0x22dedb00, aData=@0xbfffbbc0, aContext=0x248794b8, aHighestNode=0x24879490, aRuleDetail=nsRuleNode::eRulePartialReset, aCanStoreInRuleTree=1) at /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/style/nsRuleNode.cpp:4893
#10 0x11dd5c36 in nsRuleNode::WalkRuleTree (this=0x24879490, aSID=eStyleStruct_Border, aContext=0x248794b8, aRuleData=0xbfffbe14, aSpecificData=0xbfffbbc0) at nsStyleStructList.h:134

The same imgIRequest can be shared by a number of nsStyleBorder instances (and in fact, ideally should be), so either the assert is bogus or the LockImage call is bogus.

I get this every time I load layout/reftests/pixel-rounding/border-image-width-0.html, so this makes me wonder whether the patch for bug 435296 was ever run through a debug test cycle....

In any case, this is getting in the way of me testing my own fixes, since test runs always crash partway, effectively.

Comment 1

[Bobby Holley (:bholley)]

dupe of bug 516335. I'll try to get to this tonight.