Closed Bug 516661 Opened 15 years ago Closed 15 years ago

Gecko should use NPAPI directly, remove nsplugindefs.h abstractions

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file, 3 obsolete files)

nsplugindefs.h is a confusing and unnecessary layer of abstraction for our plugin implementation. It leads to bugs and makes code in our plugin implementation harder than necessary to read. It also has to be kept in sync with npapi.h to work properly, which is a pain. We should kill it off in favor of direct use of NPAPI headers.
Attached patch fix v0.9 (obsolete) — Splinter Review
Works on Linux and Mac OS X, still needs work on Windows.
Attached patch fix v1.0 (obsolete) — Splinter Review
Includes Windows support.
Attachment #400700 - Attachment is obsolete: true
Summary: remove nsplugindefs.h → Gecko should use NPAPI directly, remove nsplugindefs.h abstractions
Attached patch fix v1.1 (obsolete) — Splinter Review
Maemo fixes. This works on all tier-1 platforms now, everything builds and tests pass.
Attachment #400861 - Attachment is obsolete: true
Attachment #400930 - Flags: review?(jst)
Attached patch fix v1.2Splinter Review
more maemo fixes
Attachment #400930 - Attachment is obsolete: true
Attachment #401092 - Flags: review?(jst)
Attachment #400930 - Flags: review?(jst)
Attachment #401092 - Flags: superreview+
Attachment #401092 - Flags: review?(jst)
Attachment #401092 - Flags: review+
Comment on attachment 401092 [details] [diff] [review]
fix v1.2

This looks good! r+sr=jst
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/da6d67c2c140
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 517880
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: