If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement a way to figure out if a shell split object is inner or outer

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

Trunk
mozilla1.9.3a1
x86
Linux
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This is uglier than I was hoping for. In the process of implementing this, I realize that we don't actually outerize in the shell anymore (oops). In order to outerize, I had to add some very ugly code that might make the shell less linkable. I'm not sure if there's a nicer solutions lying around at this point. Opinions are welcome.
(Assignee)

Comment 1

8 years ago
Created attachment 400882 [details] [diff] [review]
Icky fix

Sample shell session:

$ dbg-obj/js -z
js> isInner
true
js> this.isInner
false
Attachment #400882 - Flags: review?(jorendorff)
Attachment #400882 - Flags: review?(jorendorff) → review+
Comment on attachment 400882 [details] [diff] [review]
Icky fix

You call that ugly?

I don't see which part would affect linkage -- maybe you meant the reference to js_ObjectOps? but we already have references to lots of friend-api stuff...

Anyway, ugly is beautiful when it's in service of automated tests. r=me with gusto.
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/tracemonkey/rev/3f6281924c90
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/3f6281924c90
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dc320cf0725f
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.