516828 - "Details" status in "Clear Recent History" dialog does not persist

Status: RESOLVED WONTFIX

(Firefox :: Private Browsing, defect)

Description

[pal-moz]

[STR]

open "Clear Recent History" dialog (Tools>Clear Recent History)
close "Details"
close dialog, and re-open it

regression range : 2009091404 - 2009091505 Nightly (Windows:mozilla-central)

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Dão, Ehsan: regression of Bug 488691? indented changed behavior?

btw, i noticed, that the checkboxes state isn't being persisted neither (but it wasn't before Bug 488691 too) => worth a bug report?

Comment 2

[(no longer active)]

Dao: I think passing true to prepareWarning called at <http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitizeDialog.js#93> should fix the problem (at least, restore the old behavior of not touching the visibility of the item list on dialog initialization.  Is that the expected behavior here?

Comment 3

[Dão Gottwald [:dao]]

Expanding details when the items are customized is expected behavior, per bug 488691 comment 16.

Comment 4

[(no longer active)]

WONTFIXing as per comment 3.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

What about
> btw, i noticed, that the checkboxes state isn't being persisted neither (but it
> wasn't before Bug 488691 too) => worth a bug report?

?

Comment 6

[(no longer active)]

(In reply to comment #5)
> What about
> > btw, i noticed, that the checkboxes state isn't being persisted neither (but it
> > wasn't before Bug 488691 too) => worth a bug report?
> 
> ?

What platform do you use?  On Windows, I think they shouldn't be persisted.  On Linux/Mac OS X they should already be persisted I guess.

Comment 7

[Johnathan Nightingale [:johnath]]

It's possible I'm confused, but just to be clear:

- The expected behaviour is that the details section remembers whether it was open or closed last time - if that has changed, it's a bug
- The expected behaviour is that your selections within the details (Browsing History, Cache, Cookies) are persisted as well - if that has changed, it's a bug.
- The expected behaviour is that the timespan chosen is persisted, too. If that has changed, it's also a bug.

bug 488691 comment 16 says that, in the particular case of "non-standard checkbox selections AND everything selected as the timespan" the details section should always be opened, regardless of persisted state, but otherwise the behaviour should be as I described above.

If pal-moz is saying that some of that persistence is broken, then this isn't WONTFIX, it's a regression we should fix.

Comment 8

[pal-moz]

I think

"details" open > dialog close > dialog re-open >> "details" should open
"details" close > dialog close > dialog re-open >> "details" should close

Comment 9

[(no longer active)]

Reopening based on comment 7.  Drew, do you have cycles to take this, or do you want me to?

Comment 10

[Johnathan Nightingale [:johnath]]

If I'm understanding correctly, this bug changes behaviour in a way that can cause surprising-unexpcted-dataloss scenarios, and is a regression from 3.5. Based on that understanding, this blocks 3.6. If I'm mistaken in that understanding, please renominate with an explanation.

Comment 11

[Drew Willcoxon :adw]

I can't reproduce either of the two bugs mentioned here.

1) Details expansion state:

if I OK the dialog
  if I selected Everything
    if there exists a Details pref that's non-default
      Details is expanded on reopen
    else
      Details expansion state persists on reopen
  else
    Details expansion state persists on reopen
else
  if the last time I OK'ed the dialog I selected Everything
    if there exists a Details pref that's non-default
      Details is expanded on reopen
    else
      Details expansion state persists on reopen
  else
    Details expansion state persists on reopen

2) Checkbox states:

if I OK the dialog
  checkbox states persist on reopen
else
  on reopen checkbox states are what they were when I last OK'ed the dialog

3) Timespan state (per comment 7)

if I OK the dialog
  timespan state persists on reopen
else
  on reopen timespan state is what it was when I last OK'ed the dialog

Comment 12

[Dietrich Ayala (:dietrich)]

drew seems to know what the issue is (if there is one), so assigning to him.

Comment 13

[Drew Willcoxon :adw]

As I say, I can't reproduce.  There's no bug here AFAICT.

pal-moz, could you address comment 11?

Comment 14

[pal-moz]

The behavior that I expect is comment 8 .

check/uncheck something is not an issue.

Comment 15

[Drew Willcoxon :adw]

This is wontfix, as comment 3, comment 7, and comment 11 have all said.  The intended behavior is to disregard the user's Details expansion choice when some prefs are non-default and Everything is selected.

Comment 16

[Johnathan Nightingale [:johnath]]

(In reply to comment #15)
> This is wontfix, as comment 3, comment 7, and comment 11 have all said.  The
> intended behavior is to disregard the user's Details expansion choice when some
> prefs are non-default and Everything is selected.

Yep, I agree, and I'm the one that re-opened it. Now that I understand what this bug is asking for: no, it's not the behaviour we want - it lets users forget a previous choice and end up with unexpected dataloss or data persistence. Thanks, Drew.