TM: InitGC now takes 125ms to run on Mac

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dmandelin, Unassigned)

Tracking

Trunk
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 400923 [details] [diff] [review]
Patch

I discovered that this:

#ifdef __APPLE__
    memset((void *)rt->gcBase, 0, bytes);
#endif

adds about 1/8 of a second to startup time. This is particularly painful for running test suites requiring 100-3000 invocations.

Andreas said to take it out and file a new bug to do the memory touching more efficiently.
Attachment #400923 - Flags: review?(gal)

Updated

9 years ago
Attachment #400923 - Flags: review?(gal) → review+

Comment 1

9 years ago
The sad sob story of MacOSX page fault performance continues.
(Reporter)

Comment 2

9 years ago
Pushed to TM as 615b519de189.
Whiteboard: fixed-in-tracemonkey

Comment 3

9 years ago
With the patch applied we only lose 9ms in the shell for SS so lets not worry too much (I don't think this affects the browser at all).
http://hg.mozilla.org/mozilla-central/rev/615b519de189
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 6

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e6665e2ea6f7
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.