516854 - nsTextBoxFrame::AttributeChanged never calls superclass AttributeChanged

Status: NEW

(Core :: XUL, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This manifested itself when I had a <label/> as a child of a <stack/>, where a lot of the time setting the positioning attributes on the label didn't cause a reflow (had to manually resize the window or something to get the new ones to take effect).

18:39 <@bz> vlad: oh, this is ridiculous
18:39 <@bz> vlad: I see why your bug is happening, at least.....
18:40 <@bz> <label value="whatever">
18:40 <@bz> as a child of a stack
18:40 <@bz> you'd get the same issue with <text>
18:41 <@bz> basically, the code that normally handles that attribute change is
            never called in those cases
18:41 <@bz> specifically, because nsTextBoxFrame::AttributeChanged never calls
            its superclass AttributeChanged
18:42  * bz ha no idea whether that's by-design or not
18:42 <@bz> er, has no idea
18:42 <@bz> if not, we should just fix that
18:42 <@bz> if it is, we should add some attributes to
            nsTextBoxFrame::AttributeChanged
18:42 <@bz> I think you need the services of a Neil to decide which....

Comment 1

[Boris Zbarsky [:bzbarsky]]

ccing some Neils to decide.

Comment 2

[[e-mail]]

Except that a <label/> doesn't get a box frame, it gets a leaf frame...

Comment 3

[[e-mail]]

Also the <stack> is irrelevant here.

Comment 4

[Neil Deakin]

There's a number of bugs like this. Naturally, I can't find the one I thought I'd filed anymore.

Essentially nsLeafBoxFrame::AttributeChanged should be checking a lot more attributes.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  Fun.  So we need to make nsTextBoxFrame::AttributeChanged call nsLeafBoxFrame::AttributeChanged and then fix the latter to do the right thing.