516957 - When attachment reminder pop-ups on Send, clicking "Oh, I did!" should bring up the Attach File(s) dialog box

Status: ASSIGNED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Ryan May]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090915 Namoroka/3.6a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

If I forgot to attach a file and the reminder catches it, I will then click on the "Oh, I did" option.  This then just returns you to the message where you can manually add the attachment.  Why not skip this step and have the "Oh, I did" button launch the Attach File(s) dialog box.

Reproducible: Always

Steps to Reproduce:
1.Write email with "please see attached", click Remind Me Later on attachment reminder notification
2.Press Send
3.Select "Oh I did"
Actual Results:  
Returns to message composition window

Expected Results:  
Launch the Add File(s) dialog box to select files to attach

Comment 3

[:aceman]

Josiah, would this be acceptable?

Comment 4

[Josiah Bruner [:jsbruner]]

Sure!

Comment 5

[:aceman]

Attachment: patch

This should do it.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8503519 [details] [diff] [review]
patch

Review of attachment 8503519 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Did you verify it doesn't break the test? I'd imagine it has to be adjusted.

Comment 7

[Magnus Melin [:mkmelin]]

Just tried it, and indeed the test need to adapt

Comment 8

[:aceman]

Yeah, sorry, I'll do that.

Comment 9

[:aceman]

But we should finally get bug 938829 landed before I modify the test file :)

Comment 10

[:aceman]

I talked to the mozmill guys and it seems to be very hard to check for the File picker dialog (as it is a platform native dialog in some cases, not a XUL window). I think they propose to make a 'mock' object that overrides the object opening the dialog so we could detect the dialog was about to open, we just do not really open it. I'll look into that.