More styling for search providers

VERIFIED FIXED in fennec1.0b5

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
fennec1.0b5
x86
Linux

Details

(Whiteboard: [polish])

Attachments

(7 attachments)

* Make a nicer magnifying glass
* Add some padding between magnifying glass and search buttons (1.1mm)
* Increase min-width of the search provider buttons (double it)
(Assignee)

Updated

8 years ago
tracking-fennec: --- → ?
(Assignee)

Updated

8 years ago
Duplicate of this bug: 517413
(Assignee)

Updated

8 years ago
Duplicate of this bug: 517556
Madhava Enros, from bug 517556:

The buttons in the search bar are too hard to press.  The buttons should be
made taller, which means the bar gets taller too, and also wider, to fill more
of the available space now that there are only four by default.  This means
that they can also accommodate larger text.

Let's try a bar of about 7mm tall (a touch height) -- right now, on a n900,
it's about 5mm.  For the search button text - perhaps try the same size as the
awesomebar title text (the title of a page in the list).

While we're at it, we need a little more padding between the favicon and the
label.  And the set of buttons should be set off of the magnifying glass icon
by about 16 pixels.
(In reply to comment #3)

> While we're at it, we need a little more padding between the favicon and the
> label.  And the set of buttons should be set off of the magnifying glass icon
> by about 16 pixels.

But not pixels :)

I have some of this work happening in bug 449283
(Assignee)

Updated

8 years ago
Whiteboard: polish
Right, not in pixels :)

I think we're looking for about a favicon's width, which, in their un-enlarged state, is about 2mm.
Whiteboard: polish → [polish]

Updated

8 years ago
tracking-fennec: ? → 1.0+
Closely related to this one is Bug 517997 -- about using larger icons in the place of 16x16 favicons.

Comment 7

8 years ago
Created attachment 405516 [details]
Navigation Magnifier - large

Comment 8

8 years ago
Created attachment 405517 [details]
Navigation Magnifier - small
two more padding things:
- more on the left and right of the button contents
- some padding between the favicon and search provider name

other misc
- change "Twitter Search" to "Twitter"
- change "Wikipedia (en)" to "Wikipedia"

there are other bugs about
- increasing the size of the favicons
- putting a "there's more off screen" indicator at the end of the row of buttons
Created attachment 407441 [details] [diff] [review]
patch

This patch also does:
* new search provider icons (bug 517997)
* use shorter captions for search providers (bug 523442)

I am not a fan of the new magnifying glass look
Assignee: nobody → mark.finkle
(Assignee)

Updated

8 years ago
Attachment #407441 - Flags: review?(gavin.sharp)
Attachment #407441 - Flags: review?(gavin.sharp) → review+

Comment 11

8 years ago
Created attachment 408073 [details]
Revised search glyph - 30

Comment 12

8 years ago
Created attachment 408074 [details]
Revised search glyph - 16

Comment 13

8 years ago
Created attachment 408076 [details]
Revised dark search glyph - 30

Comment 14

8 years ago
Created attachment 408077 [details]
Revised dark search glyph - 16
updated images and pushed:
https://hg.mozilla.org/mobile-browser/rev/8c92947a87d4
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.