Closed Bug 516959 Opened 15 years ago Closed 15 years ago

More styling for search providers

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0b5
Tracking Status
fennec 1.0+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Whiteboard: [polish])

Attachments

(7 files)

* Make a nicer magnifying glass
* Add some padding between magnifying glass and search buttons (1.1mm)
* Increase min-width of the search provider buttons (double it)
tracking-fennec: --- → ?
Madhava Enros, from bug 517556:

The buttons in the search bar are too hard to press.  The buttons should be
made taller, which means the bar gets taller too, and also wider, to fill more
of the available space now that there are only four by default.  This means
that they can also accommodate larger text.

Let's try a bar of about 7mm tall (a touch height) -- right now, on a n900,
it's about 5mm.  For the search button text - perhaps try the same size as the
awesomebar title text (the title of a page in the list).

While we're at it, we need a little more padding between the favicon and the
label.  And the set of buttons should be set off of the magnifying glass icon
by about 16 pixels.
(In reply to comment #3)

> While we're at it, we need a little more padding between the favicon and the
> label.  And the set of buttons should be set off of the magnifying glass icon
> by about 16 pixels.

But not pixels :)

I have some of this work happening in bug 449283
Whiteboard: polish
Right, not in pixels :)

I think we're looking for about a favicon's width, which, in their un-enlarged state, is about 2mm.
Whiteboard: polish → [polish]
tracking-fennec: ? → 1.0+
Closely related to this one is Bug 517997 -- about using larger icons in the place of 16x16 favicons.
two more padding things:
- more on the left and right of the button contents
- some padding between the favicon and search provider name

other misc
- change "Twitter Search" to "Twitter"
- change "Wikipedia (en)" to "Wikipedia"

there are other bugs about
- increasing the size of the favicons
- putting a "there's more off screen" indicator at the end of the row of buttons
Attached patch patchSplinter Review
This patch also does:
* new search provider icons (bug 517997)
* use shorter captions for search providers (bug 523442)

I am not a fan of the new magnifying glass look
Assignee: nobody → mark.finkle
Attachment #407441 - Flags: review?(gavin.sharp)
Attachment #407441 - Flags: review?(gavin.sharp) → review+
updated images and pushed:
https://hg.mozilla.org/mobile-browser/rev/8c92947a87d4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: