Attachment toolbar borders need a bit more styling on Windows

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: sid0, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 12.0
x86
Windows 7

Thunderbird Tracking Flags

(thunderbird11 fixed)

Details

Attachments

(6 attachments)

Created attachment 401018 [details]
screenshot

The blocky borders don't exactly look nice :(
(Reporter)

Updated

8 years ago
Attachment #401018 - Attachment mime type: application/octet-stream → image/png
(Assigning to Paenglab, in the hopes that he has a little time to fix it up, if it still needs fixing…)
Assignee: bwinton → richard.marti
(Assignee)

Comment 2

6 years ago
Created attachment 585150 [details] [diff] [review]
Border fixes

This patch gives other or no borders to the attachment reminder.

I fixed also the XP- and Linux theme. The Mac theme looks okay to me. It has already some styling.
Attachment #585150 - Flags: ui-review?(bwinton)
Attachment #585150 - Flags: review?(bwinton)
(Assignee)

Comment 3

6 years ago
Created attachment 585151 [details]
Screenshot with patch applied under Aero
(Assignee)

Comment 4

6 years ago
Created attachment 585152 [details]
Screenshot with patch applied under Linux

Under Ubuntu it looks a little bit weird because for the color InfoBackground this dark color is used. I gave the borders ThreeDShadow to look better under other themes.
Comment on attachment 585150 [details] [diff] [review]
Border fixes

The screenshots look nice.  ui-r=me.

>+++ b/mail/themes/qute/mail/compose/messengercompose-aero.css
>@@ -340,6 +340,14 @@
>+  #msgcomposeWindow[sizemode=normal] #attachmentNotificationBox {
>+    margin-top: -1px;
>+	border-right: 1px solid rgba(10%, 10%, 10%, .4);

Looks like you used a tab here instead of four spaces

>@@ -418,6 +426,11 @@
>+#attachmentNotificationBox > notification > .notification-inner {
>+  border: none;
>+  border-top: 1px solid ThreeDShadow;
>+}
>+

>+++ b/mail/themes/qute/mail/compose/messengercompose.css
>@@ -343,6 +343,13 @@
>+#attachmentNotificationBox > notification > .notification-inner {
>+  border-top: 1px solid ThreeDShadow;
>+  border-right: 1px solid ThreeDHighlight;
>+  border-left: 1px solid ThreeDShadow;
>+  border-bottom: none;
>+}

Why does qute get borders on the left and right, but qute-aero doesnt?

r=me with that answered, and the tab fixed.

Thanks,
Blake.
Attachment #585150 - Flags: ui-review?(bwinton)
Attachment #585150 - Flags: ui-review+
Attachment #585150 - Flags: review?(bwinton)
Attachment #585150 - Flags: review+
(Assignee)

Comment 6

5 years ago
Created attachment 587462 [details] [diff] [review]
Patch for check-in addressing comment

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #5)
> Comment on attachment 585150 [details] [diff] [review]
> 
> Looks like you used a tab here instead of four spaces

Fixed

> Why does qute get borders on the left and right, but qute-aero doesnt?

This is to match the borders of #appcontent. I add a screenshot under XP.
(Assignee)

Comment 7

5 years ago
Created attachment 587463 [details]
Screenshot with patch applied under XP
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked into trunk: http://hg.mozilla.org/comm-central/rev/a4aede33b0d4

Please request approval for branches if its needed there.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
(Assignee)

Comment 9

5 years ago
Comment on attachment 587462 [details] [diff] [review]
Patch for check-in addressing comment

You're right, this could be good if this lands on the ESR build. I checked and the patch works also on beta.
Attachment #587462 - Flags: approval-comm-beta?
Attachment #587462 - Flags: approval-comm-aurora?
Comment on attachment 587462 [details] [diff] [review]
Patch for check-in addressing comment

Not going to take this for beta as its late and just cosmetic, but we'll have it on aurora.
Attachment #587462 - Flags: approval-comm-beta?
Attachment #587462 - Flags: approval-comm-beta-
Attachment #587462 - Flags: approval-comm-aurora?
Attachment #587462 - Flags: approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/6265ae02ba19
status-thunderbird11: --- → fixed
You need to log in before you can comment on or make changes to this bug.