516970 - Attachment toolbar borders need a bit more styling on Windows

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: screenshot

The blocky borders don't exactly look nice :(

Comment 1

[Blake Winton (:bwinton) (:☕️)]

(Assigning to Paenglab, in the hopes that he has a little time to fix it up, if it still needs fixing…)

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Border fixes

This patch gives other or no borders to the attachment reminder.

I fixed also the XP- and Linux theme. The Mac theme looks okay to me. It has already some styling.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Screenshot with patch applied under Aero

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Screenshot with patch applied under Linux

Under Ubuntu it looks a little bit weird because for the color InfoBackground this dark color is used. I gave the borders ThreeDShadow to look better under other themes.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 585150 [details] [diff] [review]
Border fixes

The screenshots look nice.  ui-r=me.

>+++ b/mail/themes/qute/mail/compose/messengercompose-aero.css
>@@ -340,6 +340,14 @@
>+  #msgcomposeWindow[sizemode=normal] #attachmentNotificationBox {
>+    margin-top: -1px;
>+	border-right: 1px solid rgba(10%, 10%, 10%, .4);

Looks like you used a tab here instead of four spaces

>@@ -418,6 +426,11 @@
>+#attachmentNotificationBox > notification > .notification-inner {
>+  border: none;
>+  border-top: 1px solid ThreeDShadow;
>+}
>+

>+++ b/mail/themes/qute/mail/compose/messengercompose.css
>@@ -343,6 +343,13 @@
>+#attachmentNotificationBox > notification > .notification-inner {
>+  border-top: 1px solid ThreeDShadow;
>+  border-right: 1px solid ThreeDHighlight;
>+  border-left: 1px solid ThreeDShadow;
>+  border-bottom: none;
>+}

Why does qute get borders on the left and right, but qute-aero doesnt?

r=me with that answered, and the tab fixed.

Thanks,
Blake.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in addressing comment

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #5)
> Comment on attachment 585150 [details] [diff] [review]
> 
> Looks like you used a tab here instead of four spaces

Fixed

> Why does qute get borders on the left and right, but qute-aero doesnt?

This is to match the borders of #appcontent. I add a screenshot under XP.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Screenshot with patch applied under XP

Comment 8

[Mark Banner (:standard8)]

Checked into trunk: http://hg.mozilla.org/comm-central/rev/a4aede33b0d4

Please request approval for branches if its needed there.

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 587462 [details] [diff] [review]
Patch for check-in addressing comment

You're right, this could be good if this lands on the ESR build. I checked and the patch works also on beta.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 587462 [details] [diff] [review]
Patch for check-in addressing comment

Not going to take this for beta as its late and just cosmetic, but we'll have it on aurora.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/6265ae02ba19