Closed Bug 516971 Opened 15 years ago Closed 15 years ago

Remove lcms from the tree

Categories

(Core :: Graphics: Color Management, defect)

Product:
Core
Component:
Graphics: Color Management
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed
status1.9.1 --- .4-fixed

People

(Reporter: reed, Assigned: reed)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file, 1 obsolete file)

patch - v2
836.40 KB, patch
bholley
: review+
gerv
: review+
beltzner
: approval1.9.2+
dveditz
: approval1.9.1.4+
Details | Diff | Splinter Review
Attached patch patch - v1 (obsolete) — — Splinter Review 
lcms is dead. Long live qcms, the new reigning champ.
Attachment #401019 - Flags: review?(gerv)
Attachment #401019 - Flags: review?(bobbyholley)
Comment on attachment 401019 [details] [diff] [review]
patch - v1

In the generally-accepted ordering of Latin letters, Q comes between O and R, not S and U :-) Please put the license block, and the contents entry, in alphabetical order :-)

Gerv
Attached patch patch - v2 — — Splinter Review 
Oops. I apparently don't know my ABCs. :(
Attachment #401019 - Attachment is obsolete: true
Attachment #401043 - Flags: review?(gerv)
Attachment #401043 - Flags: review?(bobbyholley)
Attachment #401019 - Flags: review?(gerv)
Attachment #401019 - Flags: review?(bobbyholley)
Attachment #401043 - Flags: review?(gerv) → review+
Comment on attachment 401043 [details] [diff] [review]
patch - v2

r=gerv on the licence parts.

Gerv
Comment on attachment 401043 [details] [diff] [review]
patch - v2

burn baby burn.
Attachment #401043 - Flags: review?(bobbyholley) → review+
http://hg.mozilla.org/mozilla-central/rev/6ac140ebb671
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 401043 [details] [diff] [review]
patch - v2

Need to get this on 1.9.2 and 1.9.1 because of the license change.
Attachment #401043 - Flags: approval1.9.2?
Attachment #401043 - Flags: approval1.9.1.4?
Actually, while this patch is low risk, there's no legal need to have it on the branches for licensing reasons. about:license has a disclaimer saying that not all licenses may apply to every product version. We just have a license which doesn't apply to any_ product version :-)

Gerv
(In reply to comment #7)
> Actually, while this patch is low risk, there's no legal need to have it on the
> branches for licensing reasons. about:license has a disclaimer saying that not
> all licenses may apply to every product version. We just have a license which
> doesn't apply to any_ product version :-)

This patch also fixes bug 516964, which is a legal obligation... That's what I was referring to.
Comment on attachment 401043 [details] [diff] [review]
patch - v2

Approved for 1.9.1.4, a=dveditz
Attachment #401043 - Flags: approval1.9.1.4? → approval1.9.1.4+
Attachment #401043 - Flags: approval1.9.2? → approval1.9.2+
Verified for 1.9.1 in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090924 Shiretoko/3.5.4pre.
Keywords: verified1.9.1
(and source...)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: