Closed
Bug 516974
Opened 15 years ago
Closed 15 years ago
Store the overflow out of flows as an nsFrameList
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file, 1 obsolete file)
6.71 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Followup from bug 233463 comment 93:
Comment From Boris Zbarsky:
> > nsBlockFrame::GetOverflowOutOfFlows() const
> >+ return nsFrameList(result, nsLayoutUtils::GetLastSibling(result));
Maybe file a followup bug to store the overflow out of flows as an nsFrameList,
unless we're guaranteed that there aren't many of them.... And maybe even
then.
Assignee | ||
Comment 1•15 years ago
|
||
First naive version. I don't think saving/checking the old value
is necessary anymore though... new patch coming with that...
Assignee: nobody → matspal
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #402023 -
Attachment is obsolete: true
Attachment #402109 -
Flags: review?(bzbarsky)
Comment 3•15 years ago
|
||
Comment on attachment 402109 [details] [diff] [review]
Patch rev. 1
>+++ b/layout/generic/nsBlockFrame.cpp
>+nsBlockFrame::SetOverflowOutOfFlows(const nsFrameList& aList,
>+ else {
>+ SetPropTableFrames(PresContext(), new nsFrameList(aList),
>+ nsGkAtoms::overflowOutOfFlowsProperty);
This case could assert !aPropValue, right? If so, please do.
r=bzbarsky
Attachment #402109 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> This case could assert !aPropValue, right? If so, please do.
Yes, but the NS_PRECONDITION covers that. And SetPropTableFrames()
asserts that the property doesn't already exist.
Assignee | ||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•