Closed Bug 517122 Opened 15 years ago Closed 14 years ago

Remove MOZ_DEFAULT_TOOLKIT remnants(!?)

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(2 files)

(Av1-CC) Just remove them [Checkin: Comment 5]
1.42 KB, patch
kairo
: review+
Details | Diff | Splinter Review
(Bv1) Just remove them [Checkin: Comment 8]
1.41 KB, patch
ted
: review+
Details | Diff | Splinter Review 
configure.in AC_DEFINE_UNQUOTED() then AC_SUBST(), but there is nowhere to actually substitute it:
removes the lines.

I don't know what the *.vc? are...
Whiteboard: [good first bug]
Those look like visual c++ project files for an ancient version of VC++. (I think eVC4 is "Embedded Visual C++ 4.0")
Attachment #401191 - Flags: review?(kairo) → review+
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]

Mark, looking for approval actually.
Attachment #401191 - Flags: review?(bugzilla)
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]

a=Standard8
Attachment #401191 - Flags: review?(bugzilla)
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/e3b3f8f075b5
Attachment #401191 - Attachment description: (Av1-CC) Just remove them → (Av1-CC) Just remove them [Checkin: Comment 5]
Should we mark this fixed then?
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #436965 -
        Flags: review?(ted.mielczarek)

    
  
Flags: in-testsuite-
Whiteboard: [good first bug]

        Attachment #436965 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
Comment on attachment 436965 [details] [diff] [review]
(Bv1) Just remove them
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/62baa13553ff

        Attachment #436965 -
        Attachment description: (Bv1) Just remove them → (Bv1) Just remove them
[Checkin: Comment 8]

    
    

    
  
(In reply to comment #5)
> http://hg.mozilla.org/comm-central/rev/e3b3f8f075b5

Ftr, c-c was fixed before branching for c-1.9.1.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5

    
    

    
  
V.Fixed, per MXR.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: