Closed
Bug 517122
Opened 16 years ago
Closed 15 years ago
Remove MOZ_DEFAULT_TOOLKIT remnants(!?)
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files)
|
1.42 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
|
1.41 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
configure.in AC_DEFINE_UNQUOTED() then AC_SUBST(), but there is nowhere to actually substitute it:
removes the lines.
I don't know what the *.vc? are...
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [good first bug]
|
||
Comment 1•16 years ago
|
||
Those look like visual c++ project files for an ancient version of VC++. (I think eVC4 is "Embedded Visual C++ 4.0")
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #401191 -
Flags: review?(kairo)
|
||
Updated•16 years ago
|
Attachment #401191 -
Flags: review?(kairo) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]
Mark, looking for approval actually.
Attachment #401191 -
Flags: review?(bugzilla)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]
a=Standard8
Attachment #401191 -
Flags: review?(bugzilla)
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 401191 [details] [diff] [review]
(Av1-CC) Just remove them
[Checkin: Comment 5]
http://hg.mozilla.org/comm-central/rev/e3b3f8f075b5
Attachment #401191 -
Attachment description: (Av1-CC) Just remove them → (Av1-CC) Just remove them
[Checkin: Comment 5]
|
|
Assignee | |
Updated•16 years ago
|
|
||
Comment 6•15 years ago
|
||
Should we mark this fixed then?
|
|
Assignee | |
Comment 7•15 years ago
|
||
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #436965 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite-
Whiteboard: [good first bug]
|
|
||
Updated•15 years ago
|
Attachment #436965 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 8•15 years ago
|
||
Comment on attachment 436965 [details] [diff] [review]
(Bv1) Just remove them
[Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/62baa13553ff
Attachment #436965 -
Attachment description: (Bv1) Just remove them → (Bv1) Just remove them
[Checkin: Comment 8]
|
|
Assignee | |
Comment 9•15 years ago
|
||
(In reply to comment #5)
> http://hg.mozilla.org/comm-central/rev/e3b3f8f075b5
Ftr, c-c was fixed before branching for c-1.9.1.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•