517171 - need to clean up inactive controls in autoconfig window

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

Currently when the different controls in the autoconfig window is inactive, they have the inactive control appearance. We should look into making these labels instead, as it would look cleaner (and make sense for the non-failure-case).

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch for gnomestripe

patches for qute and pinstripe coming up!

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: patch for qute

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of patch

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of inactive controls (qute)

Comment 5

[Blake Winton (:bwinton) (:☕️)]

(In reply to comment #4)
> Created an attachment (id=402061) [details]
> screenshot of inactive controls (qute)

It would be kind of cool if you could get the text to line up when stuff was inactive.  (Also, you left some commented-out blocks in your patch.)  But aside from that, it looks pretty cool.  :)

Later,
Blake.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

marking this blocking as it's all that is left to fix bug 515422, which was blocking.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Andreas, are these patches ready for review?

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: patch for pinstripe

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe patch in action

Comment 10

[Andreas Nilsson (:andreasn)]

Attachment: fixes to the pinstripe dialog

the controls looked a bit inactive, there is still some css issues here that I don't know how to fix though :/

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 403760 [details] [diff] [review]
patch for pinstripe

I'm guessing that attachment 404011 [details] [diff] [review] means you're not actually done with pinstripe, and you don't actually want review on this patch?

How about just one patch for all three, without any commented-out rules, but maintaining the "all the selectors in the same order in all three themes, with commented out |/* Missing: #foopy */| for the ones that one theme doesn't need" thing that Blake worked so hard to do? Especially in the case of pinstripe, where you're adding a menulist[disabled="true"] selector a bit below the comment saying that it's missing :)

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: new patch covering all platforms

Comment 13

[Andreas Nilsson (:andreasn)]

Attachment: and one more try

after bwinton took a look at it, qute specific part is now commented out in the other two themes.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 404818 [details] [diff] [review]
and one more try

I found (on Vista) that it looked a lot better when you cleared out the drop markers completely on disable.  Otherwise they look like the old-school drop markers; disabled.

menulist[disabled="true"] > .menulist-dropmarker {
  display: none;
}

And I wonder if it's possible to make the port entry areas line up vertically for the incoming and outgoing servers.

Comment 15

[Andreas Nilsson (:andreasn)]

Attachment: patch fixing clarkbw's and philors

Comment 16

[Andreas Nilsson (:andreasn)]

Comment on attachment 405022 [details] [diff] [review]
patch fixing clarkbw's and philors

Fixing the issues raised on irc and on this bug by clarkbw and philor.

Comment 17

[Phil Ringnalda (:philor)]

Comment on attachment 405022 [details] [diff] [review]
patch fixing clarkbw's and philors

>+.menulist-dropmarker[dropmarker="true"] {
>+  visibility: hidden;

Oh, I bet that |dropmarker="true"| instead of |disabled="true"| is the reason I keep building with this, and then saying "no, this can't be the patch he meant to attach, it still has those weird Classic dropmarkers growing out of a flat background" :)

Comment 18

[Phil Ringnalda (:philor)]

Attachment: dropsabled

But barring that, I like it!

Comment 19

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 405635 [details] [diff] [review]
dropsabled

oh hey, it works! awesomes :)

Comment 20

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/409c8f8056d5