517175 - SMIME isn't really an extension - merge it and remove overlays?

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Mark Banner (:standard8)]

As mentioned in bug 516679, the code that resides in

mailnews/extensions/smime
mail/extensions/smime

doesn't really equate to an extension any more. We should consider merging it into the rest of the mailnews code base so that we've not got unnecessary overlays and code that make it easy to miss things (like the fact that caused bug 515729 in the first place).

Comment 1

[Robert Kaiser]

Additionally, saving an overlay also saves a bit of performance, AFAIK :)

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #0)
> As mentioned in bug 516679, the code that resides in
> 
> mailnews/extensions/smime
> mail/extensions/smime
> 
> doesn't really equate to an extension any more.

While we don't ship without S/MIME at all these days, having it structured to cleanly use extension points ensures that we keep the extension points working so that other similar features (eg Enigmail) can use them well.

It strikes me that the problem that caused bug 516679 wouldn't happen again now that the S/MIME code between SeaMonkey and Thunderbird has completely forked, rather than living in it's previous partially forked state.

Actually getting rid of the extension structure strikes me as throwing out the baby with the bathwater.  I suggest WONTFIX.

Comment 3

[:aceman]

And it seems there are still only about 4 files from SMIME forked between SM and TB so much of the code can be shared. Merging it into the compose files somewhere would remove the sharing and allow unnecessary diverging (even when not needed due to functionality/XUL elements differences).

I still do not understand why there must be so much divergence e.g. in the compose code (and thus these SMIME overlays) between SM and TB. I would merge them back if I could :)

Comment 4

[Wayne Mery (:wsmwk)]

wontfix?

Comment 5

[Jorg K (CEST = GMT+2)]

Mostly fixed by bug 1444606.

Comment 6

[Magnus Melin [:mkmelin]]

Yeah we don't have overlays anymore.