Closed Bug 517196 Opened 15 years ago Closed 15 years ago

The JSClass of wrappers shouldn't change when morphing from slim to XPCWrappedNative

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(2 files, 1 obsolete file)

v1
31.80 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
Additional patch v1
6.61 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
It looks like we can check the reserved slot that's used to store the XPCWrappedNativeProto for slim wrappers to distinguish between slim and XPCWrappedNative wrappers.
Attached patch WIP (obsolete) — — Splinter Review 
With this the browser starts up, but haven't done any testing. Also need to check that it doesn't regress performance.
Attached patch v1 — — Splinter Review 
Doesn't regress Dromaeo DOM performance tests.
Attachment #401202 - Attachment is obsolete: true
Attachment #401449 - Flags: review?(mrbkap)
Attachment #401449 - Flags: review?(mrbkap) → review+

        Attachment #405370 -
        Flags: review?(mrbkap)

        Attachment #405370 -
        Flags: review?(mrbkap) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/90cf93ac3435
http://hg.mozilla.org/mozilla-central/rev/1d467b956f7e

and bustage fix

http://hg.mozilla.org/mozilla-central/rev/b28baef2e923
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: