517307 - Some tabs opened in background from middle clicks still focus the browser

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

The existing openNewTabWith method used to open link clicks in a new tab does not raise the browser if it was configured to open a new tab in the background. The new openUILinkIn method however focuses the browser with the new tab, although this seems pointless as we deliberately didn't switch to the new tab.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I thought moving the focus() calls was neater than fiddling around with setting loadInBackground to false when opening in an existing window.

I cleaned up the code for opening multiple tabs slightly.

Note that these functions differ from the openNewTabWith family in that they are designed for links in chrome, not in content.

Comment 2

[Ian Neal]

Comment on attachment 401274 [details] [diff] [review]
Proposed patch

Is it worth making openUILinkIn call openUILinkArrayIn seeing the former is just a special case of the latter?

Comment 3

[[e-mail]]

Comment on attachment 401274 [details] [diff] [review]
Proposed patch

I think that openUILinkIn is sufficiently simpler to make it worth keeping separate.

Comment 4

[[e-mail]]

Pushed changeset 043683cd4f96 to comm-central.