Closed
Bug 517308
Opened 15 years ago
Closed 15 years ago
TM merge: Part II set of changes from Tracemonkey
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rreitmai, Assigned: rreitmai)
References
Details
Attachments
(17 files)
A collection of patches extracted from the Tracemonkey branch and rebased to apply against tamarin redux. The patches will be posted in order of application and rely on the landing of early patches outlined in 515539, 515548 and 515822 respectively. Each patch represents a check-in and associated patch from the Tracemonkey branch. Bug numbers will be specified for each of the patches.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #401276 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #401279 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #401282 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #401284 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #401285 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 6•15 years ago
|
||
|
|
Assignee | |
Comment 7•15 years ago
|
||
Attachment #401288 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 8•15 years ago
|
||
Attachment #401290 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 9•15 years ago
|
||
Attachment #401292 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 10•15 years ago
|
||
Attachment #401296 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 11•15 years ago
|
||
Attachment #401297 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 12•15 years ago
|
||
Attachment #401300 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 13•15 years ago
|
||
Attachment #401301 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 14•15 years ago
|
||
Attachment #401302 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 15•15 years ago
|
||
Attachment #401304 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 16•15 years ago
|
||
Attachment #401305 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 17•15 years ago
|
||
Attachment #401306 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #401286 -
Attachment description: bug 512646 → bug 512646 - regalloc cleaning
Attachment #401286 -
Flags: superreview?(edwsmith)
|
||
Updated•15 years ago
|
Attachment #401276 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401279 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401282 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401284 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 18•15 years ago
|
||
Comment on attachment 401285 [details] [diff] [review] bug 514537 Please don't re-add the NJ_LOG2_PAGE_SIZE = 12 constant in NativeX64.h
Attachment #401285 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401286 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 19•15 years ago
|
||
Comment on attachment 401288 [details] [diff] [review] bug 514503 - sanity filter This is based on the ValidateFilter in CodegenLIR.cpp, but is missing a bunch of other instruction categories. lets make sure we remove the duplicate code from ValidateFilter ASAP.
Attachment #401288 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401290 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401292 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401296 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401297 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401300 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 20•15 years ago
|
||
Comment on attachment 401301 [details] [diff] [review] bug 514532 - lir 64b helpers looks like we have some redundant helpers in CodegenLIR.cpp that can be removed due to this patch (i'm thinking of u2p() and i2p())
Attachment #401301 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401302 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401304 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Updated•15 years ago
|
Attachment #401305 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 21•15 years ago
|
||
Comment on attachment 401306 [details] [diff] [review] bug 513787 - epilogue and jumptable curious how this ends up looking on tamarin where we have >1 LIR_ret per method (it occurs each place an OP_returnvalue occurs in ABC)
Attachment #401306 -
Flags: superreview?(edwsmith) → superreview+
|
|
Assignee | |
Comment 22•15 years ago
|
||
re comment #18 : done re comment #19 : created bug 517561 re comment #20 : created bug 517560 re comment #21 : doesn't seem to move the needle for us (at least on the tests I've run) but TM reports a modest gain
|
|
Assignee | |
Comment 23•15 years ago
|
||
pushed en masse starting from : http://hg.mozilla.org/tamarin-redux/rev/504bcef895e8 ending at: http://hg.mozilla.org/tamarin-redux/rev/de7a597eea3a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 24•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•