517315 - Donations page sends base64NONSENSE data to the paypal page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[/\/\arcio Galli]

I don't know how come but I was able to get a donation even after AMO sent this base64.. chunk of data as being the purpose of the donation.

* Attached image has the problem

How to reproduce: 

* Go to my addon page: https://addons.mozilla.org/pt-BR/firefox/addon/10284 
* Click donate
* Check the problem
* Feel free to donate ( optional  but not required to check this bug : )

Comment 1

[/\/\arcio Galli]

Attachment: Donate page problem

Comment 2

[Jeff Balogh (:jbalogh)]

This is what we send to paypal for the problem addon:

Location: https://www.paypal.com/cgi-bin/webscr?cmd=_donations&&item_name=Contribui%C3%A7%C3%A3o+para+PinkTheme+Pink+Pack+&item_number=6ade21f323099145eb3392ae240353ea

This is what we send for Threadbubble, which has no problems:
Location: https://www.paypal.com/cgi-bin/webscr?cmd=_donations&item_name=Contribution+for+ThreadBubble&item_number=b3cfa16d6ab0e360360805626976d891

(I took out the unimportant parts.)

Notice the unicode escaping for the PinkTheme item_name since I went to Paypal 
from /pt-BR/.  I'm guessing that's where Paypal is dying since it works fine for
en-US (PinkTheme looks fine when going from en-US).

I'd like to believe that we're doing the right thing with that URL encoding and
Paypal is just dumb, since that would support my grand worldview.  Can anyone 
confirm?

Comment 3

[/\/\arcio Galli]

Pinged some info about this bug to the paypal feedback forms channel.

Comment 4

[Wil Clouser [:clouserw]]

Attachment: tell paypal we're using utf-8

Comment 5

[Jeff Balogh (:jbalogh)]

Comment on attachment 401851 [details] [diff] [review]
tell paypal we're using utf-8

gd unicode!

Comment 6

[Wil Clouser [:clouserw]]

r51976

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.mozilla.org/pt-BR/firefox/addons/contribute/10284?source=addon-detail.