517409 - IOConnectMethodStructureIStructureO not available to 64-bit application

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

IOConnectMethodStructureIStructureO was deprecated in Mac OS X 10.5 and can't be used by 64-bit applications. We need to find a replacement or make the accelerometer service available only to 32-bit applications using __LP64__ ifdefs. This blocks 64-bit Gecko, bug 468509.

Comment 1

[Doug Turner (:dougt)]

From Apple migration documentation:

Replace outdated IOConnectMethod* calls—The following functions are not supported in a 64-bit environment:
	•	IOConnectMethodScalarIScalarO
	•	IOConnectMethodScalarIStructureO
	•	IOConnectMethodScalarIStructureI
	•	IOConnectMethodStructureIStructureO
	•	IOConnectMethodScalarIScalarO
	•	IOConnectMethodScalarIStructureO
	•	IOConnectMethodScalarIStructureI
	•	IOConnectMethodStructureIStructureO

You should instead use the IOConnectCall* functions:
	•	IOConnectCallMethod
	•	IOConnectCallAsyncMethod
	•	IOConnectCallStructMethod
	•	IOConnectCallAsyncStructMethod
	•	IOConnectCallScalarMethod
	•	IOConnectCallAsyncScalarMethod

Comment 2

[Josh Aas]

Attachment: fix v1.0

This uses the new API when 10.5 is our minimum, the old API when 10.4 is the minimum. It is 64-bit safe and adds a bounds check for the iokit all output.

I don't have a laptop with me right now so this needs to be tested when it is reviewed.

Comment 3

[Doug Turner (:dougt)]

looks fine to me too.

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/aae349de03be