517416 - Increase the tab-close image and expand the "hit" area so it is easier to click

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

It's hard to hit the tab-close image in the thumbnails to close a tab. The image is currently 30px. We should increase to 40px and also expand the transparent clickable area around the close button so it's easier to close tabs.

Comment 1

[Madhava Enros [:madhava]]

If we can do it, the tappable area should be the full height of the tab thumbnail, even though the visible button is not that tall.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Madhava, do we have the 40px image for that?

Comment 3

[Madhava Enros [:madhava]]

I'll get one from Sean - will post here.

Comment 4

[Sean Martell]

Attachment: Close Tab PNG - 40px

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I wondering if I need to change the wince themes too?
Actually this patch increase the tappable area to be full height for both platform but I've changed the icon only on hildon.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 405531 [details] [diff] [review]
Patch

I'll add it to wince/browser-high too.

I think the HTC could have the same problems

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/7593031b6df1

Comment 8

[Aakash Desai [:aakashd]]

This is great, verified FIXED On builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091013 Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091013
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091013
Fennec/1.0b5pre