Sync will not complete, causing firefox not to quit successfully

VERIFIED FIXED in 0.8

Status

Cloud Services
Firefox Sync: Backend
P1
major
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Judson, Assigned: Mardak)

Tracking

unspecified
x86
Windows XP
Points:
---
Bug Flags:
blocking-weave1.0 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3

If I leave firefox open for too long a sync will happen that will not complete. If this happens, when I quit FF, it seems like it quit ok, but firefox.exe is still running. When you re-open it you get the normal "already running" error.

Reproducible: Sometimes

Steps to Reproduce:
1. Open firefox
2. Wait for a sync that never stops
3. Quit firefox
Actual Results:  
Firefox.exe stays running preventing re-launch

Expected Results:  
firefox.exe will quit
(Assignee)

Comment 1

8 years ago
Most likely sync-async keeping the loop spinning. We should listen for app shutdown? And push it to jsmodules too.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-weave1.0+
(Assignee)

Updated

8 years ago
Target Milestone: --- → 0.8
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/labs/weave/rev/881eb9a527b4
Lazily listen for quit-application on the first sync-async call and bail out if the notification is sent while waiting for the callback. 

Should probably add a test and land this on the js modules repository if this method of checking for app-quit is okay.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Priority: -- → P1

Comment 3

8 years ago
flagging in-testsuite? for unit tests to cover.   Manually verified fix on weave 1.3b5
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.