517492 - Sync will not complete, causing firefox not to quit successfully

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Judson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3

If I leave firefox open for too long a sync will happen that will not complete. If this happens, when I quit FF, it seems like it quit ok, but firefox.exe is still running. When you re-open it you get the normal "already running" error.

Reproducible: Sometimes

Steps to Reproduce:
1. Open firefox
2. Wait for a sync that never stops
3. Quit firefox
Actual Results:  
Firefox.exe stays running preventing re-launch

Expected Results:  
firefox.exe will quit

Comment 1

[Ed Lee :Mardak]

Most likely sync-async keeping the loop spinning. We should listen for app shutdown? And push it to jsmodules too.

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/881eb9a527b4
Lazily listen for quit-application on the first sync-async call and bail out if the notification is sent while waiting for the callback. 

Should probably add a test and land this on the js modules repository if this method of checking for app-quit is okay.

Comment 3

[Tony Chung [:tchung]]

flagging in-testsuite? for unit tests to cover.   Manually verified fix on weave 1.3b5