Closed
Bug 517507
Opened 15 years ago
Closed 15 years ago
correctly format talos results that are measured in bytes
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: anodelman, Assigned: anodelman)
Details
Attachments
(1 file, 2 obsolete files)
1.78 KB,
patch
|
catlee
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
Stopped working correctly when we moved to using tp4.
Attachment #401476 -
Flags: review?(catlee)
Comment 1•15 years ago
|
||
Comment on attachment 401476 [details] [diff] [review] smarter identification of metrics measured in bytes >+ if memory_metric.find(linkName) > -1: #measured in bytes I think this should be if memory_metric in linkName or if linkName.find(memory_metric) > 1:
Attachment #401476 -
Flags: review?(catlee) → review-
Assignee | ||
Comment 2•15 years ago
|
||
Both work, but if we prefer this stylistically than I don't mind.
Attachment #401476 -
Attachment is obsolete: true
Attachment #401529 -
Flags: review?(catlee)
Assignee | ||
Comment 3•15 years ago
|
||
Both previous patches don't work. I have more confidence in this one.
Attachment #401529 -
Attachment is obsolete: true
Attachment #401541 -
Flags: review?(catlee)
Attachment #401529 -
Flags: review?(catlee)
Updated•15 years ago
|
Attachment #401541 -
Flags: review?(catlee) → review+
Comment 4•15 years ago
|
||
Comment on attachment 401541 [details] [diff] [review] smarter identification of metrics measured in bytes (take 3) Checking in run_tests.py; /cvsroot/mozilla/testing/performance/talos/run_tests.py,v <-- run_tests.py new revision: 1.53; previous revision: 1.52 done
Attachment #401541 -
Flags: checked-in+
Assignee | ||
Comment 5•15 years ago
|
||
Done like dinner.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•