correctly format talos results that are measured in bytes

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: anodelman, Assigned: anodelman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 401476 [details] [diff] [review]
smarter identification of metrics measured in bytes

Stopped working correctly when we moved to using tp4.
Attachment #401476 - Flags: review?(catlee)
Comment on attachment 401476 [details] [diff] [review]
smarter identification of metrics measured in bytes

>+      if memory_metric.find(linkName) > -1: #measured in bytes

I think this should be

if memory_metric in linkName

or

if linkName.find(memory_metric) > 1:
Attachment #401476 - Flags: review?(catlee) → review-
(Assignee)

Comment 2

9 years ago
Created attachment 401529 [details] [diff] [review]
smarter identification of metrics measured in bytes (take 2)

Both work, but if we prefer this stylistically than I don't mind.
Attachment #401476 - Attachment is obsolete: true
Attachment #401529 - Flags: review?(catlee)
(Assignee)

Comment 3

9 years ago
Created attachment 401541 [details] [diff] [review]
smarter identification of metrics measured in bytes (take 3)

Both previous patches don't work.  I have more confidence in this one.
Attachment #401529 - Attachment is obsolete: true
Attachment #401541 - Flags: review?(catlee)
Attachment #401529 - Flags: review?(catlee)

Updated

9 years ago
Attachment #401541 - Flags: review?(catlee) → review+
Comment on attachment 401541 [details] [diff] [review]
smarter identification of metrics measured in bytes (take 3)

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.53; previous revision: 1.52
done
Attachment #401541 - Flags: checked-in+
(Assignee)

Comment 5

9 years ago
Done like dinner.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.