Closed Bug 517509 Opened 14 years ago Closed 11 years ago

drag and drop rss feed link from browser to folderpane does nothing

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 13.0

People

(Reporter: ovidiu.grigorescu, Assigned: alta88)

References

Details

(Keywords: regression, Whiteboard: [no l10n impact])

Attachments

(1 file, 1 obsolete file)

patch
1.12 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

Drag and drop rss link from FF to folderpane simply never works

STR
-have TB with a blog and feeds account
-have a page with rss link
-drag from browser to account or folder under Blogs

a.it appears possible, highlight etc but nothing happens
b.it appears possible,""http...link" not a valid feed" brief status bar message
[same works if added manually, same works if dragged into the manage/add url field]

there are several older bugs to touch this and some new ones, but I don't seam to find precisely this, though it surely is out there [thus dupeme!]
 Bug 252859, Bug 256777, Bug 516929 and others
Some testing with WinXP
Open a page in firefox with http://pearce.org.nz/2009/09/ogg-video-seek-performance-improvements.html

Look at the feed link in the lower right hand corner. It has the structure:
<a target="_blank" href="http://pearce.org.nz/atom.xml" type="application/atom+xml">Atom</a>

Attempt to drag and drop that link into News and Blogs and you get:
"http://pearce.org.nz/atom.xmlAtom" could not be found in the status bar.

It seems the link text "Atom" has been appended to the feed URL
That I'm sure I've seen mention of, but it would be an enormous help if someone could find the one-day window in nightly builds when it started happening.
Flags: blocking-thunderbird3?
This seems WFM in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

Wayne, what about Vista?
XP on another machine, brand new profile only rss folder and some subscriptions

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090810 Shredder/3.0b4pre
and then
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090921 Shredder/3.0pre



Error: not well-formed
Source File: http://www.nytimes.com/services/xml/rss/nyt/Dance.xmlDance
Line: 1, Column: 62
Source Code:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"/>

where the actual link (as in FF) is 
http://www.nytimes.com/services/xml/rss/nyt/Dance.xml
not
http://www.nytimes.com/services/xml/rss/nyt/Dance.xmlDance

same works like a charm if dragged into the Feed Subscriptions panel and brings the field with the correct url and folder to choose. So there's a difference between subscribe window and the folderpane in the way they interpret the dropped address.
oh, fwiw, beta3 not working also
using 090922 nightly and http://pearce.org.nz/atom.xml I get 

Error: syntax error
Source file: http://pearce.org.nz/atom.xmlAtom
Line: 1, Column: 50
Source code:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
Whiteboard: [no l10n impact]
With Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1b1pre) Gecko/20081006 Shredder/3.0a3 ID:20081006095651

Drag and Drop works

With Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1b3pre) Gecko/20081204 Thunderbird/3.0b1 ID:20081204115318

Drag and Drop is not working
We'd love to get this, but wouldn't block on it, since it's not a regression from Tb2.  Note that the current regression windows is very wide, doing a binary search on builds to narrow it down to (ideally) a particular build would be very helpful.
Flags: blocking-thunderbird3? → blocking-thunderbird3-
To avoid confusion, the reasoning here is that as far as we know, while this was a regression from an alpha, it didn't work in Tb2.
=> with version 2.0.0.23 (20090812)

Drag & Drop works

=> with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081112 Shredder/3.0b1pre ID:20081112031406

Drag & Drop works

=> with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Shredder/3.0b1pre ID:20081113031301

Drag & Drop doesn't work
(In reply to comment #8)
> We'd love to get this, but wouldn't block on it, since it's not a regression
> from Tb2.  Note that the current regression windows is very wide, doing a
> binary search on builds to narrow it down to (ideally) a particular build would
> be very helpful.

It was cantalou first or second contribution to QA yesterday and he ran out of time before completing hence the initial wide window.

(In reply to comment #10)
> => with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre)
> Gecko/20081112 Shredder/3.0b1pre ID:20081112031406
> 
> Drag & Drop works
> 
> => with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre)
> Gecko/20081113 Shredder/3.0b1pre ID:20081113031301

Thanks for finishing the work !

Looking at http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-11-12&enddate=2008-11-13 this looks like a regression from bug 414038.
Blocks: 414038
Keywords: regressionwindow-wanted → regression
jminta, if you have any ideas, jump in =)

(cantalou: thanks indeed -- getting a narrow regression window is super helpful)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch patch (obsolete) — — Splinter Review 
incorrect data transfer type is being used, just the url is wanted.
Assignee: nobody → alta88
Attachment #597026 - Flags: review?(dbienvenu)
OK, my problem is that I can't drag drop to the news and blogs line, i.e., the top level container, which is what I want to do. I can't do that with or without this patch. This is on Windows; I'm dragging the xml links from this page - http://sportsillustrated.cnn.com/services/rss/

If I go into the subscribe UI, and have the top level News and Blogs line selected, I can't get the Add button to be enabled either.
that's because that specific xml link is being assigned a data transfer type of "application/x-moz-file", and that type is handled before the feed code in the drop() function in the folderpane code.  it's not related to bug 716706.  dragging the link from, say, https://addons.mozilla.org/en-us/thunderbird/extensions/?sort=featured page should work.

this patch fixes the second problem of a url string being incorrectly joined with \n+title, thus being a bad url when passed to the feed interface.

dragging the same xml link onto the Subscribe dialog root folder works for me.  if a feed is selected, Add is disabled, if a folder is selected, Add is enabled - for pasting a url.  for dnd, the Add button or current selection is not relevant.
more specifically, "application/x-moz-file" is assigned if you dnd the xml image (a tmp file is created).  dnd urls  onto folderpane wfm, with this patch.
Attached patch patch — — Splinter Review 
this updated patch handles the image link dnd case, as well as fixing the data transfer type to get the url only.
Attachment #597026 - Attachment is obsolete: true
Attachment #597505 - Flags: review?(dbienvenu)
Attachment #597026 - Flags: review?(dbienvenu)
Comment on attachment 597505 [details] [diff] [review]
patch

thx, that works for me.
Attachment #597505 - Flags: review?(dbienvenu) → review+
Keywords: checkin-needed
OS: Windows Vista → All
Hardware: x86 → All
Checked in: http://hg.mozilla.org/comm-central/rev/74aecd7c865c
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.