Closed Bug 517567 Opened 13 years ago Closed 13 years ago

NJ: ARM asm_arg does not handle LIR_ldq in register parameters with softfloat

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dvander, Assigned: gal)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fix (obsolete) — Splinter Review
No description provided.
Attachment #401538 - Flags: review?(gal)
Attachment #401538 - Attachment is obsolete: true
Attachment #401538 - Flags: review?(gal)
Attached patch patch (obsolete) — Splinter Review
Instead we can also just make sure that all arguments have a qjoin before they go into the call. This is what Adobe's soft filter does.
Assignee: general → gal
Attachment #401544 - Attachment is obsolete: true
Copy Adobe's SoftFloatFilter code. Its equivalent but covered a few cases we didn't. The _ci vs ci_ name mangling is different. We should coordinate to make those match and then share the code in nanojit/*. For now copying it will do.
Attachment #401546 - Flags: review?(dvander)
Attachment #401546 - Flags: review?(dvander) → review+
Doug, can you test this patch?
@gal works fine.  thanks for your and David's help!
Check-in needed for TM and m-c.
Keywords: checkin-needed
Blocks: 517210
http://hg.mozilla.org/tracemonkey/rev/d71ed6573c4a
http://hg.mozilla.org/mozilla-central/rev/0f8644e0ff55
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #401546 - Attachment description: patch → patch [Checkin: Comment 7]
Where else do you want this to land?
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.