Closed Bug 517584 Opened 10 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | test_bug480619.html

Categories

(Core :: Security, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: zpao, Assigned: azakai)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

First seen:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1253287598.1253298205.5821.gz#err4
OS X 10.5.2 mozilla-1.9.2 unit test on 2009/09/18 08:26:38

5784 INFO Running chrome://mochikit/content/chrome/security/ssl/bugs/test_bug480619.html...
5785 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/security/ssl/bugs/test_bug480619.html | The stream should be inside an error state - got 2152398861, expected 2147500037
5786 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/security/ssl/bugs/test_bug480619.html | The stream should be closed after a teardown of secure decoder ring

Possibly related to bug 517579, which occurred at the same time.
OS X 10.5.2 mozilla-central test everythingelse on 2009/09/23 18:18:45
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1253755125.1253756400.21116.gz
Blocks: 438871
Attached patch patchSplinter Review
This intermittent orange became almost permanently orange with the patch for bug 591881. On the upside, that allowed it to be debugged more easily.

Looks like the issue is that pruning of dead connections needs to be done after logging out/breaking sockets. Without that, this worked almost always anyhow since pruning was done frequently enough, but with the patch for bug 591881 it is only done when actually needed, and it became much more of an issue.

This patch (meant to be applied on top of the abovementioned patch) forces pruning dead connections at the right point, when logging out/breaking sockets. See discussion in bug 480619 for more on that.

dwitte, you're already up to speed on the other patch, want to review this one as well?
Attachment #483240 - Flags: review?(dwitte)
Blocks: 591881
Comment on attachment 483240 [details] [diff] [review]
patch

Looks fine; I'm trusting that your analysis of the problem is correct! ;)

r=dwitte.
Attachment #483240 - Flags: review?(dwitte) → review+
http://hg.mozilla.org/mozilla-central/rev/65d85a6e96d7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → azakai
Target Milestone: --- → mozilla2.0b8
Version: 1.9.2 Branch → Trunk
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.