Created attachment 401604 [details] [diff] [review] proposed fix Microsoft's x64 compiler does not support inline assembly, we must use the __cpuid intrinsic instead. Additionally x64 CPUs will always have CPUID, so there's no need to perform a runtime check.
cpu.c was cribbed from libtheora, so upstream might want these fixes too. We're we're not hitting this case at build time in libtheora because we build without USE_ASM of x86-64.
The patch needs to be updated to include a .patch file that can be used to re-apply it when we update to new versions of libtheora, a line added to update.sh to apply the patch and a description added to README_MOZILLA referring to this bug. See how other patches have been done in the various /media subdirectories for examples.
Comment on attachment 401604 [details] [diff] [review] proposed fix r+ with changes mentioned in comment 2
This bug is already merged on upstream. http://git.xiph.org/?p=liboggplay.git;a=commitdiff;h=b908ed69267c001310cc234628fb4c7dc41ced76
Was this fixed by bug 512328? I updated liboggplay yesterday.
(In reply to comment #5) > Was this fixed by bug 512328? I updated liboggplay yesterday. Yes. About cpu.c issue, this is fixed. But I found other problem. (I found simple typo bug of x64 issue in yuv2rgb_x86_vs.h). About it, I will file a bug to xiph.org.
Fixed on trunk and 1.9.2 by bug 512328 checkin.
Fixed on trunk and 1.9.1 by bug 512328 checkin.