517658 - When adding MozOrientation listener, the listener is called only after there is orientation change

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

I think this is a regression. We don't get the event somewhat soon after
adding the listener. And we should, so that web app can know the current
orientation.
At least on mac I need to wait several seconds before I get the first event (if I don't move the laptop).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Probably a regression from bug 512237, since that added the -1,1 checks.
This could be solved by adding values outside -1,1 or
setting values to be always within -1,1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Without this getting fixed, the event is pretty useless :(

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

we need to do at least what the patch does.
Or we can wait until bug 513910 is fixed.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I know in some bug I argued that this is not the right thing to do, and it isn't,
but at least it is better than current behavior :/

Comment 6

[Doug Turner (:dougt)]

i would rather just drop the check complete (eg. fix 513910).

Comment 7

[Doug Turner (:dougt)]

olli, do you want to post a patch that just removes that filtering and update the idl?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Not until I know the answer to https://bugzilla.mozilla.org/show_bug.cgi?id=513910#c2

Comment 9

[Doug Turner (:dougt)]

answered.

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 401617 [details] [diff] [review]
patch

lets to with this.  Maybe we should have a separate event that exposed actual force.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Yeah, this is not perfect but works quite well in common cases.

Perhaps we could report avg of previous N accelerometer values to get
more "correct" orientation and have separate thing for force.

http://hg.mozilla.org/mozilla-central/rev/ced7e965f6dc

Comment 12

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fc607d2689a3