Closed
Bug 517694
Opened 16 years ago
Closed 16 years ago
Remove actions box from mozad.css
Categories
(support.mozilla.org :: Knowledge Base Software, task)
support.mozilla.org
Knowledge Base Software
Tracking
(Not tracked)
VERIFIED
FIXED
1.4.2
People
(Reporter: cilias, Assigned: paulc)
References
()
Details
(Whiteboard: sumo_only)
Attachments
(1 file)
|
673 bytes,
patch
|
jsocol
:
review+
|
Details | Diff | Splinter Review |
When we removed the print option from articles, that eft an empty actions box on 'how to contribute' articles. HTC articles already have "edit, remove, translation, etc." links at the bottom of the articles anyway, so lets remove the actions box.
| Assignee | ||
Updated•16 years ago
|
Assignee: nobody → paulc
Target Milestone: 1.4.1 → 1.4.2
| Assignee | ||
Comment 1•16 years ago
|
||
One of those ~1 line patches.
Attachment #404485 -
Flags: review?(james)
Comment 2•16 years ago
|
||
We removed the print option? I remember talking about doing it, but I still see "Print" in the box on prod and stage.
Comment 3•16 years ago
|
||
Comment on attachment 404485 [details] [diff] [review]
v1
Works for me.
Attachment #404485 -
Flags: review?(james) → review+
| Reporter | ||
Comment 4•16 years ago
|
||
(In reply to comment #2)
> We removed the print option? I remember talking about doing it, but I still see
> "Print" in the box on prod and stage.
We disabled it for bug 463184, but as a result pages that use mozad.css had an empty actions box. So the print option was put back until this bug is fixed.
Comment 5•16 years ago
|
||
Ok, well this patch does a fine job of removing the box, so it should be OK now.
| Assignee | ||
Comment 6•16 years ago
|
||
r53854 (trunk)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 7•16 years ago
|
||
Verified FIXED; http://support-stage.mozilla.org/en-US/kb/Contributing+to+the+Knowledge+Base doesn't have the Actions box, but http://support.mozilla.com/en-US/kb/Contributing+to+the+Knowledge+Base does.
Status: RESOLVED → VERIFIED
Comment 8•16 years ago
|
||
Does this need to be committed to the mobile branch as well?
| Assignee | ||
Comment 9•16 years ago
|
||
I'd say yes. If they plan to use the mozad.css theme and have the print feature disabled.
| Reporter | ||
Comment 10•16 years ago
|
||
Yes, definitely.
| Assignee | ||
Comment 11•16 years ago
|
||
| Reporter | ||
Updated•16 years ago
|
Whiteboard: remove print option after push
| Reporter | ||
Comment 12•16 years ago
|
||
Print option disabled on prod
Whiteboard: remove print option after push
Updated•16 years ago
|
Whiteboard: sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•