Last Comment Bug 517700 - Lightning Categories Pref pane not showing any categories
: Lightning Categories Pref pane not showing any categories
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Lightning: SeaMonkey Integration (show other bugs)
: Trunk
: All All
: -- normal (vote)
: 1.0b1
Assigned To: Philip Chee
:
Mentors:
Depends on: 516398
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-19 11:42 PDT by Ian Neal
Modified: 2011-11-07 02:39 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 Use document.documentElement instead. (1.51 KB, patch)
2009-09-27 08:25 PDT, Philip Chee
mschroeder: review+
Details | Diff | Splinter Review

Description Ian Neal 2009-09-19 11:42:37 PDT
Using SeaMonkey with Lightning the preferences pane for categories is not showing any categories.
Error console shows:
Error: parentPrefWindow is null
Source File: chrome://calendar/content/preferences/categories.js
Line: 64
Comment 1 Ian Neal 2009-09-19 11:49:18 PDT
Should be able to use document.documentElement.instantApply?
Comment 2 neil@parkwaycc.co.uk 2009-09-19 12:11:05 PDT
Well, you might want to keep the parentPrefWindow variable, but yes.
Comment 3 Philip Chee 2009-09-27 08:25:59 PDT
Created attachment 403111 [details] [diff] [review]
Patch v1.0 Use document.documentElement instead.

(Comment #1 From  Ian Neal)
> Should be able to use document.documentElement.instantApply?

(Comment #2 From neil)
> Well, you might want to keep the parentPrefWindow variable, but yes.

This patch switches to using document.documentElement. I've tested this and it works in TB+Lighting, SM+Lightning, and in Sunbird.
Comment 4 Martin Schröder [:mschroeder] 2009-10-03 09:45:09 PDT
Comment on attachment 403111 [details] [diff] [review]
Patch v1.0 Use document.documentElement instead.

r=mschroeder
Comment 5 Philip Chee 2009-10-06 02:30:15 PDT
Checked in to comm-central
http://hg.mozilla.org/comm-central/rev/96065ab23c15
Comment 6 Philipp Kewisch [:Fallen] 2011-11-07 02:39:41 PST
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Note You need to log in before you can comment on or make changes to this bug.